GNU bug report logs - #54201
[PATCH] Add wego

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54201 in the body.
You can then email your comments to 54201 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add wego
Date: Tue, 01 Mar 2022 01:29:35 +0100

[Message part 1 (text/plain, inline)]

Hello,

The following two patches add wego. I create a new "weather.scm" file
since I didn't know where to put it.

Regards,
-- 
Nicolas Goaziou

[0001-gnu-Add-go-github-com-schachmat-ingo.patch (text/x-diff, attachment)]

[0002-gnu-Add-wego.patch (text/x-diff, attachment)]

Message #8 received at 54201 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 54201 <at> debbugs.gnu.org
Subject: Re: bug#54201: [PATCH] Add wego
Date: Fri, 18 Mar 2022 14:59:00 +0100

Hi,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>>From 84b5ea4501014800ec43b6335af6b554716f8ce0 Mon Sep 17 00:00:00 2001
> Message-Id: <84b5ea4501014800ec43b6335af6b554716f8ce0.1646094084.git.mail <at> nicolasgoaziou.fr>
> In-Reply-To: <b8ff68982388247600aa8f4771e6ccd5794acf0e.1646094084.git.mail <at> nicolasgoaziou.fr>
> References: <b8ff68982388247600aa8f4771e6ccd5794acf0e.1646094084.git.mail <at> nicolasgoaziou.fr>
> From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> Date: Tue, 1 Mar 2022 01:14:04 +0100
> Subject: [[PATCH] 2/2] gnu: Add wego.
>
> * gnu/packages/weather.scm: New file.
> * gnu/local.mk: Register new file.

[...]

> +++ b/gnu/packages/weather.scm
> @@ -0,0 +1,34 @@
> +(define-module (gnu packages weather)

Please add a license header.


[...]

> +    (home-page "https://github.com/schachmat/wego")
> +    (synopsis "Weather client for the terminal")
> +    (description "@strong{wego} is a weather client for the terminal.")

Could you expound a little bit, mentioning key features, etc.?

You can prolly remove @strong.

> +    (license isc)))

Perhaps #:prefix license: ?

Otherwise LGTM, thanks!

Ludo’.

Message #13 received at 54201-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54201-done <at> debbugs.gnu.org
Subject: Re: bug#54201: [PATCH] Add wego
Date: Sat, 19 Mar 2022 00:59:09 +0100

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>> +++ b/gnu/packages/weather.scm
>> @@ -0,0 +1,34 @@
>> +(define-module (gnu packages weather)
>
> Please add a license header.

Done.

>> +    (description "@strong{wego} is a weather client for the terminal.")
>
> Could you expound a little bit, mentioning key features, etc.?
>
> You can prolly remove @strong.

Done.

>> +    (license isc)))
>
> Perhaps #:prefix license: ?

I thought we needed to use the prefix only when there was a conflict in
the module.

Anyhow, done.

> Otherwise LGTM, thanks!

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.