GNU bug report logs - #54201
[PATCH] Add wego

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: bug#54201: closed (Re: bug#54201: [PATCH] Add wego)
Date: Sat, 19 Mar 2022 00:00:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#54201: [PATCH] Add wego

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 54201 <at> debbugs.gnu.org.

-- 
54201: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54201
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 54201-done <at> debbugs.gnu.org
Subject: Re: bug#54201: [PATCH] Add wego
Date: Sat, 19 Mar 2022 00:59:09 +0100

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

>> +++ b/gnu/packages/weather.scm
>> @@ -0,0 +1,34 @@
>> +(define-module (gnu packages weather)
>
> Please add a license header.

Done.

>> +    (description "@strong{wego} is a weather client for the terminal.")
>
> Could you expound a little bit, mentioning key features, etc.?
>
> You can prolly remove @strong.

Done.

>> +    (license isc)))
>
> Perhaps #:prefix license: ?

I thought we needed to use the prefix only when there was a conflict in
the module.

Anyhow, done.

> Otherwise LGTM, thanks!

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add wego
Date: Tue, 01 Mar 2022 01:29:35 +0100

[Message part 4 (text/plain, inline)]

Hello,

The following two patches add wego. I create a new "weather.scm" file
since I didn't know where to put it.

Regards,
-- 
Nicolas Goaziou

[0001-gnu-Add-go-github-com-schachmat-ingo.patch (text/x-diff, attachment)]

[0002-gnu-Add-wego.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.