GNU bug report logs - #54180
[PATCH 00/12] Home: Clarify and better test symlink-manager.scm

Previous Next

Full log

Message #59 received at 54180 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>, 54180 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: [bug#54180] [PATCH 00/12] Home: Clarify and better test
 symlink-manager.scm
Date: Mon, 28 Feb 2022 10:53:18 +0300

[Message part 1 (text/plain, inline)]

On 2022-02-27 14:40, Ludovic Courtès wrote:

> Hello Guix!
>
> This patch set aims to increase test coverage for ‘guix home reconfigure’,
> to make symlink-manager.scm IMO easier to follow, and to have it more
> closely follow the project’s conventions.
>
> Functionality is unchanged.
>
> Thoughts?

That's great!  symlink-manager was a little messy for sure.

I took a brief look; On first glance patches seems good.  I'll take a
deep look later, when will be updating patch for bug#52808 and will
report or make a separate patch if something pop up.

Thank you very much for working on this :)

>
> Thanks,
> Ludo’.
>
> Ludovic Courtès (12):
>   home: symlink-manager: Clarify module imports.
>   home: symlink-manager: Move helper procedures as top-level defines.
>   home: symlink-manager: Use 'for-each' when used for effects.
>   home: symlink-manager: Use 'file-is-directory?'.
>   home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU
>     race.
>   home: symlink-manager: Avoid extra 'lstat' call.
>   tests: Make sure 'guix home reconfigure' backs up files.
>   tests: Simplify use of 'local-file' in 'tests/guix-home.sh'.
>   tests: Check 'guix home reconfigure' for a second generation.
>   home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'.
>   home: symlink-manager: 'create-symlinks' uses 'file-system-fold'.
>   home: symlink-manager: Rename "path" to "file" where appropriate.
>
>  gnu/home/services/symlink-manager.scm | 355 ++++++++++++--------------
>  tests/guix-home.sh                    |  44 +++-
>  2 files changed, 198 insertions(+), 201 deletions(-)
>
>
> base-commit: 33ce3f1c866231a3015411fdce18a3e72649e2f6

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.