GNU bug report logs - #54179
28.0.91; tab-first-completion defcustom :type specification

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54179 in the body.
You can then email your comments to 54179 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.91; tab-first-completion defcustom :type specification
Date: Sun, 27 Feb 2022 10:07:55 -0300

Hi All,

I've been trying out the pre-release and met the new 
`tab-first-completion' which looks interesting.

However, the `:type' specification of its `defcustom' quotes the non-nil 
values of the choice options, and it shouldn't.

Indeed, if one tries to set it with the customization interface, one 
gets something like the following in `custom-set-variables':

#+begin_src emacs-lisp
'(tab-first-completion ''word-or-paren)
#+end_src

And if one does set it outside the customization interface, one gets a 
mismatch for it.

Also, I think the `eol' tag is imprecise.  The docstring for the 
defcustom states "When `eol', only complete if point is at the end of a 
line.", while the `:tag` says "Unless at the end of a line".  As far as 
I understand the code and the intent here, the docstring seems to be 
correct, and the `:tag' needs adjustment to something like "Only at the 
end of a line".

Best regards,
Gustavo.


In GNU Emacs 28.0.91 (build 2, x86_64-pc-linux-gnu, GTK+ Version 
3.24.20, cairo version 1.16.0)
of 2022-02-26 built on gusbrs-laptop
Windowing system distributor 'The X.Org Foundation', version 
11.0.12013000
System Description: Linux Mint 20.2

Configured using:
'configure --with-mailutils --with-xwidgets --with-modules
--with-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

Important settings:
 value of $LC_MONETARY: pt_BR.UTF-8
 value of $LC_NUMERIC: pt_BR.UTF-8
 value of $LANG: en_US.UTF-8
 locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
 tooltip-mode: t
 global-eldoc-mode: t
 eldoc-mode: t
 show-paren-mode: t
 electric-indent-mode: t
 mouse-wheel-mode: t
 tool-bar-mode: t
 menu-bar-mode: t
 file-name-shadow-mode: t
 global-font-lock-mode: t
 font-lock-mode: t
 blink-cursor-mode: t
 auto-composition-mode: t
 auto-encryption-mode: t
 auto-compression-mode: t
 line-number-mode: t
 indent-tabs-mode: t
 transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug comp comp-cstr warnings rx cl-extra
help-mode message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa
derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json map text-property-search time-date subr-x seq
byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads
xwidget-internal dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit
x multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 85982 7426)
(symbols 48 7858 2)
(strings 32 21613 3032)
(string-bytes 1 749030)
(vectors 16 16934)
(vector-slots 8 330239 15295)
(floats 8 28 37)
(intervals 56 200 0)
(buffers 992 11))

Message #8 received at 54179 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: 54179 <at> debbugs.gnu.org
Subject: Re: bug#54179: 28.0.91; tab-first-completion defcustom :type
 specification
Date: Sun, 27 Feb 2022 14:14:52 +0100

Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

> However, the `:type' specification of its `defcustom' quotes the non-nil 
> values of the choice options, and it shouldn't.

This has been fixed on the emacs-28 branch, and the fix will be in the
next pre-release.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 54179 <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54179 <at> debbugs.gnu.org
Subject: Re: bug#54179: 28.0.91; tab-first-completion defcustom :type
 specification
Date: Sun, 27 Feb 2022 10:23:44 -0300

On Sun, 27 Feb 2022 at 14:14, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> This has been fixed on the emacs-28 branch, and the fix will be in the
> next pre-release.

Oh, sorry for the redundant report, I missed it in my search at the 
list.  And thank you for the prompt response.

However, if I got the blob right (I'm presuming 
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/indent.el?h=emacs-28), 
the quoted values are correct, but the tag for `eol' still seems not to 
correspond to the doctring.

Best regards,
Gustavo.

Message #16 received at 54179 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: 54179 <at> debbugs.gnu.org
Subject: Re: bug#54179: 28.0.91; tab-first-completion defcustom :type
 specification
Date: Mon, 28 Feb 2022 10:14:15 +0100

Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

> However, if I got the blob right (I'm presuming
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/indent.el?h=emacs-28),
> the quoted values are correct, but the tag for `eol' still seems not
> to correspond to the doctring.

Yup; now fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 54179 <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 54179 <at> debbugs.gnu.org
Subject: Re: bug#54179: 28.0.91; tab-first-completion defcustom :type
 specification
Date: Mon, 28 Feb 2022 07:04:13 -0300

On Mon, 28 Feb 2022 at 10:14, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Yup; now fixed.

Thank you.

Best,
Gustavo.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.