GNU bug report logs - #54180
[PATCH 00/12] Home: Clarify and better test symlink-manager.scm

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: 54180 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, Andrew Tropin <andrew <at> trop.in>, Oleg Pykhalov <go.wigust <at> gmail.com>, Xinglu Chen <public <at> yoctocell.xyz>
Subject: [bug#54180] [PATCH 00/12] Home: Clarify and better test symlink-manager.scm
Date: Sun, 27 Feb 2022 14:40:06 +0100

Hello Guix!

This patch set aims to increase test coverage for ‘guix home reconfigure’,
to make symlink-manager.scm IMO easier to follow, and to have it more
closely follow the project’s conventions.

Functionality is unchanged.

Thoughts?

Thanks,
Ludo’.

Ludovic Courtès (12):
  home: symlink-manager: Clarify module imports.
  home: symlink-manager: Move helper procedures as top-level defines.
  home: symlink-manager: Use 'for-each' when used for effects.
  home: symlink-manager: Use 'file-is-directory?'.
  home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU
    race.
  home: symlink-manager: Avoid extra 'lstat' call.
  tests: Make sure 'guix home reconfigure' backs up files.
  tests: Simplify use of 'local-file' in 'tests/guix-home.sh'.
  tests: Check 'guix home reconfigure' for a second generation.
  home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'.
  home: symlink-manager: 'create-symlinks' uses 'file-system-fold'.
  home: symlink-manager: Rename "path" to "file" where appropriate.

 gnu/home/services/symlink-manager.scm | 355 ++++++++++++--------------
 tests/guix-home.sh                    |  44 +++-
 2 files changed, 198 insertions(+), 201 deletions(-)


base-commit: 33ce3f1c866231a3015411fdce18a3e72649e2f6
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.