GNU bug report logs - #54151
gnu: Add #:log-file option when starting openvpn shepherd services

Previous Next

Package: guix-patches;

Reported by: Cameron Chaparro <cameron <at> cameronchaparro.com>

Date: Thu, 24 Feb 2022 22:25:02 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54151: closed (gnu: Add #:log-file option when starting
 openvpn shepherd services)
Date: Thu, 03 Mar 2022 22:34:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 03 Mar 2022 23:32:52 +0100
with message-id <878rtqvf8r.fsf <at> gnu.org>
and subject line Re: bug#54151: gnu: Add #:log-file option when starting openvpn shepherd services
has caused the debbugs.gnu.org bug report #54151,
regarding gnu: Add #:log-file option when starting openvpn shepherd services
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54151: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54151
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Cameron Chaparro <cameron <at> cameronchaparro.com>
To: guix-patches <at> gnu.org
Subject: gnu: Add #:log-file option when starting openvpn shepherd services
Date: Thu, 24 Feb 2022 16:23:47 -0600
[Message part 3 (text/plain, inline)]
I accidentally submitted this to bug-guix, first, sorry.

---------- Forwarded message ---------
From: Cameron Chaparro <cameron <at> cameronchaparro.com>
Date: Thu, Feb 24, 2022 at 4:11 PM
Subject: openvpn-shepherd-service is not writing log files
To: <bug-guix <at> gnu.org>

I noticed that the `openvpn-shepherd-service' is defining, but not
actually using, the log file when starting the client/server. I think
this patch should address that issue.

Cameron Chaparro
[Message part 4 (text/html, inline)]
[0001-gnu-Add-log-file-option-when-starting-openvpn-shephe.patch (text/x-patch, attachment)]
[Message part 6 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Cameron Chaparro <cameron <at> cameronchaparro.com>
Cc: 54151-done <at> debbugs.gnu.org
Subject: Re: bug#54151: gnu: Add #:log-file option when starting openvpn
 shepherd services
Date: Thu, 03 Mar 2022 23:32:52 +0100
Hi,

Cameron Chaparro <cameron <at> cameronchaparro.com> skribis:

> +++ b/gnu/services/vpn.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
>  ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
>  ;;; Copyright © 2021 Nathan Dehnel <ncdehnel <at> gmail.com>
> +;;; Copyright © 2022 Cameron V Chaparro <cameron <at> cameronchaparro.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -494,7 +495,8 @@ (define (openvpn-shepherd-service role)
>                         (list (string-append #$openvpn "/sbin/openvpn")
>                               "--writepid" #$pid-file "--config" #$config-file
>                               "--daemon")
> -                       #:pid-file #$pid-file))
> +                       #:pid-file #$pid-file
> +                       #:log-file #$log-file))
>               (stop #~(make-kill-destructor)))))))

I adjusted the commit log and applied it, thanks!

Ludo’.


This bug report was last modified 3 years and 80 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.