GNU bug report logs - #54151
gnu: Add #:log-file option when starting openvpn shepherd services

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54151 in the body.
You can then email your comments to 54151 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cameron Chaparro <cameron <at> cameronchaparro.com>
To: guix-patches <at> gnu.org
Subject: gnu: Add #:log-file option when starting openvpn shepherd services
Date: Thu, 24 Feb 2022 16:23:47 -0600

[Message part 1 (text/plain, inline)]

I accidentally submitted this to bug-guix, first, sorry.

---------- Forwarded message ---------
From: Cameron Chaparro <cameron <at> cameronchaparro.com>
Date: Thu, Feb 24, 2022 at 4:11 PM
Subject: openvpn-shepherd-service is not writing log files
To: <bug-guix <at> gnu.org>

I noticed that the `openvpn-shepherd-service' is defining, but not
actually using, the log file when starting the client/server. I think
this patch should address that issue.

Cameron Chaparro

[Message part 2 (text/html, inline)]

[0001-gnu-Add-log-file-option-when-starting-openvpn-shephe.patch (text/x-patch, attachment)]

Message #10 received at 54151-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Cameron Chaparro <cameron <at> cameronchaparro.com>
Cc: 54151-done <at> debbugs.gnu.org
Subject: Re: bug#54151: gnu: Add #:log-file option when starting openvpn
 shepherd services
Date: Thu, 03 Mar 2022 23:32:52 +0100

Hi,

Cameron Chaparro <cameron <at> cameronchaparro.com> skribis:

> +++ b/gnu/services/vpn.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
>  ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
>  ;;; Copyright © 2021 Nathan Dehnel <ncdehnel <at> gmail.com>
> +;;; Copyright © 2022 Cameron V Chaparro <cameron <at> cameronchaparro.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -494,7 +495,8 @@ (define (openvpn-shepherd-service role)
>                         (list (string-append #$openvpn "/sbin/openvpn")
>                               "--writepid" #$pid-file "--config" #$config-file
>                               "--daemon")
> -                       #:pid-file #$pid-file))
> +                       #:pid-file #$pid-file
> +                       #:log-file #$log-file))
>               (stop #~(make-kill-destructor)))))))

I adjusted the commit log and applied it, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.