GNU bug report logs - #54061
thermald-2.4.7 build fail following upower update to 0.99.15

Previous Next

Package: guix;

Reported by: Paul Jewell <paul <at> teulu.org>

Date: Fri, 18 Feb 2022 18:33:01 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54061 <at> debbugs.gnu.org, Paul Jewell <paul <at> teulu.org>
Subject: bug#54061: thermald-2.4.7 build fail following upower update to 0.99.15
Date: Sat, 19 Feb 2022 21:52:53 +0100
Hello,

Maxime Devos <maximedevos <at> telenet.be> writes:

>       `(#:configure-flags
> -       (let ((out (assoc-ref %outputs "out")))
> -         (list (string-append "--with-dbus-sys-dir="
> -                              out "/etc/dbus-1/system.d")
> -               "--localstatedir=/var"))
> +       ,#~(list (string-append "--with-dbus-sys-dir="
> +                               #$output "/etc/dbus-1/system.d")
> +                "--localstatedir=/var")

The patches look good, but I'm not sure it is a good idea to publicize
the unquote+ungexp, alias ",#~", style. IIUC, in
<https://guix.gnu.org/fr/blog/2021/the-big-change/> there's some
reasoning against the abuse of unquoting. This kind of defeat the
simplicity introduced with G-expressions. So, I would favor writing:

 (list
  #:configure-flags
  #~(list ...))

WDYT?

Regards,
-- 
Nicolas Goaziou




This bug report was last modified 3 years and 139 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.