GNU bug report logs - #54061
thermald-2.4.7 build fail following upower update to 0.99.15

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54061 in the body.
You can then email your comments to 54061 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Jewell <paul <at> teulu.org>
To: bug-guix <at> gnu.org
Subject: thermald-2.4.7 build fail following upower update to 0.99.15
Date: Fri, 18 Feb 2022 17:07:32 +0000

When building thermald-2.4.7, I am getting a build failure:

------------8<---------------------
src/thd_engine_adaptive.cpp: In member function ‘int 
cthd_engine_adaptive::evaluate_lid_condition(condition)’:
src/thd_engine_adaptive.cpp:1002:61: error: ‘gboolean 
up_client_get_lid_is_closed(UpClient*)’ is deprecated 
[-Werror=deprecated-declarations
]

------------8<---------------------

According to jpoiret (via IRC), this is due to the upower update from 
0.99.13 to 0.99.15, and the marking of the "up_client_get_lid_is_closed" 
function as deprecated.

I am not sure where the compiler flag setting is made turning this 
warning into an error. I have no configuration in my system config which 
could be doing this (at least not explicitly).

Message #8 received at 54061 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Paul Jewell <paul <at> teulu.org>, 54061 <at> debbugs.gnu.org
Subject: Re: bug#54061: thermald-2.4.7 build fail following upower update to
 0.99.15
Date: Sat, 19 Feb 2022 15:55:39 +0100

[Message part 1 (text/plain, inline)]

Paul Jewell schreef op vr 18-02-2022 om 17:07 [+0000]:
> When building thermald-2.4.7, I am getting a build failure:
> 
> [... deprecation error ...]


The attached two patches should fix this.

Greetings,
Maxime.

[0001-gnu-thermald-Use-G-expressions.patch (text/x-patch, attachment)]

[0002-gnu-thermald-Fix-build-failure.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 54061 <at> debbugs.gnu.org (full text, mbox):

From: Paul Jewell <paul <at> teulu.org>
To: 54061 <at> debbugs.gnu.org
Subject: bug#54061: thermald-2.4.7 build fail following upower update to
 0.99.15
Date: Sat, 19 Feb 2022 14:15:16 +0000

I have reported this upstream: 
https://github.com/intel/thermal_daemon/issues/340

It seems the problem was known (at least by the upower developers) for 9 
months, but there was no comment on the thermald github issue list.

Message #14 received at 54061 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54061 <at> debbugs.gnu.org, Paul Jewell <paul <at> teulu.org>
Subject: Re: bug#54061: thermald-2.4.7 build fail following upower update to
 0.99.15
Date: Sat, 19 Feb 2022 21:52:53 +0100

Hello,

Maxime Devos <maximedevos <at> telenet.be> writes:

>       `(#:configure-flags
> -       (let ((out (assoc-ref %outputs "out")))
> -         (list (string-append "--with-dbus-sys-dir="
> -                              out "/etc/dbus-1/system.d")
> -               "--localstatedir=/var"))
> +       ,#~(list (string-append "--with-dbus-sys-dir="
> +                               #$output "/etc/dbus-1/system.d")
> +                "--localstatedir=/var")

The patches look good, but I'm not sure it is a good idea to publicize
the unquote+ungexp, alias ",#~", style. IIUC, in
<https://guix.gnu.org/fr/blog/2021/the-big-change/> there's some
reasoning against the abuse of unquoting. This kind of defeat the
simplicity introduced with G-expressions. So, I would favor writing:

 (list
  #:configure-flags
  #~(list ...))

WDYT?

Regards,
-- 
Nicolas Goaziou

Message #17 received at 54061 <at> debbugs.gnu.org (full text, mbox):

From: Paul Jewell <paul <at> teulu.org>
To: Maxime Devos <maximedevos <at> telenet.be>, 54061 <at> debbugs.gnu.org
Subject: Re: bug#54061: thermald-2.4.7 build fail following upower update to
 0.99.15
Date: Sat, 19 Feb 2022 20:58:49 +0000

On 19/02/2022 14:55, Maxime Devos wrote:
> Paul Jewell schreef op vr 18-02-2022 om 17:07 [+0000]:
>> When building thermald-2.4.7, I am getting a build failure:
>>
>> [... deprecation error ...]
> 
> 
> The attached two patches should fix this.
> 
> Greetings,
> Maxime.

Hi Maxime,
Many thanks for this - with the patches everything builds OK.

I also noted a pull request is outstanding for thermald which will 
remove the need for the deprecated functions, so hopefully the changes 
can be reversed with the next version of thermald.

When do you think these patches can be merged (notwithstanding the 
comments from Nicolas of course)?

Best regards,
Paul

Message #22 received at 54061-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Guillaume Le Vaillant <glv <at> posteo.net>, 54061-done <at> debbugs.gnu.org,
 Paul Jewell <paul <at> teulu.org>
Subject: Re: bug#54061: thermald-2.4.7 build fail following upower update to
 0.99.15
Date: Wed, 02 Mar 2022 18:03:37 +0100

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> From d066a7dcd11757fb19edc79028104f7dbcffeab1 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Sat, 19 Feb 2022 14:52:17 +0000
> Subject: [PATCH 2/2] gnu: thermald: Fix build failure.
>
> * gnu/packages/admin.scm (thermald)[arguments]<#:configure-flags>: Add
> '--disable-werror'.
>
> Fixes: <https://issues.guix.gnu.org/54061>
> Reported-by: Paul Jewell <paul <at> teulu.org>

Guillaume fixed it independently in commit
73db69bea15e390a31289fdfadb1d5b9a7d13557.

Closing!

Ludo’.

Message #25 received at 54061-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Jewell <paul <at> teulu.org>
To: Ludovic Courtès <ludo <at> gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>
Cc: Guillaume Le Vaillant <glv <at> posteo.net>, 54061-done <at> debbugs.gnu.org
Subject: Re: bug#54061: thermald-2.4.7 build fail following upower update to
 0.99.15
Date: Thu, 3 Mar 2022 16:33:05 +0000

[Message part 1 (text/plain, inline)]

Good afternoon,

Thanks Ludo, and also Maxime and Guillaume.

Upstream have also merged a fix to the original problem, so I guess the 
change made here can be removed again after the next release.

Best regards,
Paul

On 02/03/2022 17:03, Ludovic Courtès wrote:
> Hi,
>
> Maxime Devos<maximedevos <at> telenet.be>  skribis:
>
>>  From d066a7dcd11757fb19edc79028104f7dbcffeab1 Mon Sep 17 00:00:00 2001
>> From: Maxime Devos<maximedevos <at> telenet.be>
>> Date: Sat, 19 Feb 2022 14:52:17 +0000
>> Subject: [PATCH 2/2] gnu: thermald: Fix build failure.
>>
>> * gnu/packages/admin.scm (thermald)[arguments]<#:configure-flags>: Add
>> '--disable-werror'.
>>
>> Fixes:<https://issues.guix.gnu.org/54061>
>> Reported-by: Paul Jewell<paul <at> teulu.org>
> Guillaume fixed it independently in commit
> 73db69bea15e390a31289fdfadb1d5b9a7d13557.
>
> Closing!
>
> Ludo’.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.