GNU bug report logs - #54019
[PATCH] doc: Fix 'setuid-program' example.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#54019: closed ([PATCH] doc: Fix 'setuid-program' example.)
Date: Thu, 24 Feb 2022 04:18:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 23 Feb 2022 23:17:37 -0500
with message-id <87fso8lwym.fsf <at> gmail.com>
and subject line Re: bug#54019: [PATCH] doc: Fix 'setuid-program' example.
has caused the debbugs.gnu.org bug report #54019,
regarding [PATCH] doc: Fix 'setuid-program' example.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
54019: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54019
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] doc: Fix 'setuid-program' example.
Date: Wed, 16 Feb 2022 01:18:40 +0000

[Message part 3 (text/plain, inline)]

On #guix an error was reported in adding a setuid-program, but which followed the example in the manual. Looks like %setuid-programs was moved out a level in 1b87dc2f2a897f5fe0b3f8984c2544335ac87b56. The indentation was misleading (implying %setuid-programs was in the list sexp) previous to that commit.

I believe this should be the correct format, and Kolev (who had the setuid-program problem on #guix) reported moving the paren fixed the error.

Please see the attached patch. I did not add a copyright line for fixing this typo, but if it should be added, please do.

Thanks!
John

[0001-doc-Fix-setuid-program-example.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 54019-done <at> debbugs.gnu.org
Subject: Re: bug#54019: [PATCH] doc: Fix 'setuid-program' example.
Date: Wed, 23 Feb 2022 23:17:37 -0500

Hello,

John Kehayias <john.kehayias <at> protonmail.com> writes:

> On #guix an error was reported in adding a setuid-program, but which
> followed the example in the manual. Looks like %setuid-programs was
> moved out a level in 1b87dc2f2a897f5fe0b3f8984c2544335ac87b56. The
> indentation was misleading (implying %setuid-programs was in the list
> sexp) previous to that commit.
>
> I believe this should be the correct format, and Kolev (who had the
> setuid-program problem on #guix) reported moving the paren fixed the
> error.
>
> Please see the attached patch. I did not add a copyright line for
> fixing this typo, but if it should be added, please do.

It's not needed, no (as per the <= 10 changed lines rule of thumb).

Pushed as 50311f338f.

Thanks to all involved :-).

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.