GNU bug report logs - #54019
[PATCH] doc: Fix 'setuid-program' example.

Previous Next

Package: guix-patches;

Reported by: John Kehayias <john.kehayias <at> protonmail.com>

Date: Wed, 16 Feb 2022 01:19:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54019 in the body.
You can then email your comments to 54019 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#54019; Package guix-patches. (Wed, 16 Feb 2022 01:19:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to John Kehayias <john.kehayias <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 16 Feb 2022 01:19:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] doc: Fix 'setuid-program' example.
Date: Wed, 16 Feb 2022 01:18:40 +0000

[Message part 1 (text/plain, inline)]
On #guix an error was reported in adding a setuid-program, but which followed the example in the manual. Looks like %setuid-programs was moved out a level in 1b87dc2f2a897f5fe0b3f8984c2544335ac87b56. The indentation was misleading (implying %setuid-programs was in the list sexp) previous to that commit.

I believe this should be the correct format, and Kolev (who had the setuid-program problem on #guix) reported moving the paren fixed the error.

Please see the attached patch. I did not add a copyright line for fixing this typo, but if it should be added, please do.

Thanks!
John
[0001-doc-Fix-setuid-program-example.patch (text/x-patch, attachment)]
Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Thu, 24 Feb 2022 04:18:01 GMT) Full text and rfc822 format available.
Notification sent to John Kehayias <john.kehayias <at> protonmail.com>:
bug acknowledged by developer. (Thu, 24 Feb 2022 04:18:02 GMT) Full text and rfc822 format available.

Message #10 received at 54019-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 54019-done <at> debbugs.gnu.org
Subject: Re: bug#54019: [PATCH] doc: Fix 'setuid-program' example.
Date: Wed, 23 Feb 2022 23:17:37 -0500

Hello,

John Kehayias <john.kehayias <at> protonmail.com> writes:

> On #guix an error was reported in adding a setuid-program, but which
> followed the example in the manual. Looks like %setuid-programs was
> moved out a level in 1b87dc2f2a897f5fe0b3f8984c2544335ac87b56. The
> indentation was misleading (implying %setuid-programs was in the list
> sexp) previous to that commit.
>
> I believe this should be the correct format, and Kolev (who had the
> setuid-program problem on #guix) reported moving the paren fixed the
> error.
>
> Please see the attached patch. I did not add a copyright line for
> fixing this typo, but if it should be added, please do.

It's not needed, no (as per the <= 10 changed lines rule of thumb).

Pushed as 50311f338f.

Thanks to all involved :-).

Maxim
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Mar 2022 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 87 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.