GNU bug report logs - #53893
Fix non-sequencer from failing to build

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53893 in the body.
You can then email your comments to 53893 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sughosha <at> disroot.org
To: guix-patches <at> gnu.org
Subject: Fix non-sequencer from failing to build
Date: Wed, 09 Feb 2022 03:46:02 +0000

[Message part 1 (text/plain, inline)]

[Message part 2 (text/html, inline)]

[fix-non-sequencer.patch (application/octet-stream, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: sughosha--- via Guix-patches via <guix-patches <at> gnu.org>
Cc: 53893 <at> debbugs.gnu.org
Subject: Re: [bug#53893] Fix non-sequencer from failing to build
Date: Wed, 9 Feb 2022 14:02:27 -0500

On Wed, Feb 09, 2022 at 03:46:02AM +0000, sughosha--- via Guix-patches via wrote:
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index ddb1126a47..5a67a6e0d2 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -1773,7 +1773,7 @@ (define-public non-sequencer
>                       '()))
>           #:python ,python-2))
>        (inputs
> -       (list jack-1 libsigc++ liblo ntk))
> +       (list jack-1 libsigc++-2 liblo ntk))
>        (native-inputs
>         (list pkg-config))
>        (home-page "https://non.tuxfamily.org/wiki/Non%20Sequencer")

Thanks! I confirm it fixes the issue.

Normally I would push your change now. However, I'm not sure who to
credit for the fix.

You are free to use any name and email address that you prefer,
including pseudonyms.

Because this is your first patch (and would be your first commit in our
Git repo), I want to check with you what you want to appear in the Git
author field and the list of authors of 'gnu/packages/music.scm':

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/music.scm

As you continue to contribute, you can learn how to follow the steps
in the manual section Submitting Patches, and then your patches will
include this info when they are sent.

Message #14 received at 53893 <at> debbugs.gnu.org (full text, mbox):

From: sughosha <at> disroot.org
To: 53893 <at> debbugs.gnu.org
Subject: Re: [bug#53893] Fix non-sequencer from failing to build
Date: Thu, 10 Feb 2022 11:18:17 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thanks for considoring this patch. Crediting me as `Sughosha <sughosha <at> disroot.org>` would be fine. I look forward to learn how to include this while sending the patch.

Regards,
Sughosha

[Message part 2 (text/html, inline)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: sughosha--- via Guix-patches via <guix-patches <at> gnu.org>
Cc: 53893-done <at> debbugs.gnu.org
Subject: Re: [bug#53893] Fix non-sequencer from failing to build
Date: Sun, 13 Feb 2022 19:26:10 -0500

On Thu, Feb 10, 2022 at 11:18:17AM +0000, sughosha--- via Guix-patches via wrote:
> Hi,
> 
> Thanks for considoring this patch. Crediting me as `Sughosha <sughosha <at> disroot.org>` would be fine.

Okay, I pushed your fix as commit
6bfb3fc1f450c7d618041303d0ff35691b5991c0:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6bfb3fc1f450c7d618041303d0ff35691b5991c0

> I look forward to learn how to include this while sending the patch.

If you use Git to contribute to Guix, then your work will include
authorship information as part of the commits that you generate patches
from.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.