GNU bug report logs - #53880
[PATCH 0/2] Fix build of protonvpn-cli

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53880: closed ([PATCH 0/2] Fix build of protonvpn-cli)
Date: Sat, 12 Feb 2022 13:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 12 Feb 2022 14:21:15 +0100
with message-id <87h794w790.fsf <at> waegenei.re>
and subject line Re: bug#53880: [PATCH 0/2] Fix build of protonvpn-cli
has caused the debbugs.gnu.org bug report #53880,
regarding [PATCH 0/2] Fix build of protonvpn-cli
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53880: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53880
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH 0/2] Fix build of protonvpn-cli
Date: Tue,  8 Feb 2022 19:03:33 +0100

Hello,

These two patches fix the build failure of protonvpn-cli.  The first
one fixes the wrap target, since the wrapper code now properly handles
re-wrapping a wrapped binary.  The second removes the sanity-check
phase as the main entry point tries to create a directory under ~user,
which fails, and setting HOME=/tmp will not work since expanding ~user
uses the passwd database.

Best,

Josselin Poiret (2):
  gnu: protonvpn-cli: Do not try to wrap the wrapper.
  gnu: protonvpn-cli: Remove sanity-check phase.

 gnu/packages/vpn.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 53855-done <at> debbugs.gnu.org, 53880-done <at> debbugs.gnu.org
Subject: Re: bug#53880: [PATCH 0/2] Fix build of protonvpn-cli
Date: Sat, 12 Feb 2022 14:21:15 +0100

Hello Josselin,

Josselin Poiret <dev <at> jpoiret.xyz> writes:

> Josselin Poiret (2):
>   gnu: protonvpn-cli: Do not try to wrap the wrapper.
>   gnu: protonvpn-cli: Remove sanity-check phase.
>
>  gnu/packages/vpn.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Thank you for the patch, it fixes <https://bugs.gnu.org/53855>. I've build the
package and ran the binary succesfully.  It's pushed as
9c8f68f4796f23c11173fa3f90c69bc85b224ac6 with an added copyright header.

Cheers,
- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.