GNU bug report logs - #53879
[PATCH] gnu: Add emacs-everywhere.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53879 in the body.
You can then email your comments to 53879 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-everywhere.
Date: Tue, 08 Feb 2022 20:47:38 +0530

[0001-gnu-Add-emacs-everywhere.patch (text/x-patch, inline)]

From f8f503e5aea4515340d9f7b86ad96ceb4bb71502 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Date: Tue, 8 Feb 2022 20:44:05 +0530
Subject: [PATCH] gnu: Add emacs-everywhere.

* gnu/packages/emacs-xyz.scm (emacs-everywhere): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 56af72b2ab..c891a71250 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26279,6 +26279,32 @@ (define-public emacs-evil-tmux-navigator
 Emacs windows and tmux panes.")
     (license license:expat)))
 
+(define-public emacs-everywhere
+  ;; No upstream release.  Extract version from main file.
+  (let ((revision "0") (version "0.0.1")
+        (commit "ace53396a66ed4b753f42c04a5a0db2bcd770423"))
+    (package
+      (name "emacs-everywhere")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/tecosaur/emacs-everywhere")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0p55shxvqm1713af33mfglny7rpi31d42wvgwylcsfy4jvnsq8bb"))))
+      (propagated-inputs
+       (list xclip xdotool xprop xwininfo))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/tecosaur/emacs-everywhere")
+      (synopsis "System-wide popup Emacs windows for quick edits")
+      (description "@code{emacs-everywhere} launches a new Emacs frame, and the
+contents of the buffer are pasted into the previously focused application on
+deletion of the frame.")
+      (license license:gpl3+))))
+
 (define-public emacs-xclip
   (package
     (name "emacs-xclip")

base-commit: 35d56676db0988aad6d1a5b52dc4efef578885f2
-- 
2.34.0

Message #8 received at 53879 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Cc: 53879 <at> debbugs.gnu.org
Subject: Re: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Tue, 08 Feb 2022 18:29:27 +0100

Hello,

Jai Vetrivelan <jaivetrivelan <at> gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-everywhere.

Thanks. Some comments follow.

> +(define-public emacs-everywhere
> +  ;; No upstream release.  Extract version from main file.
> +  (let ((revision "0") (version "0.0.1")

Nitpick: binding should go to separate lines. However, in this case,
I suggest to move version string right in the "version" field. It will
make life of the updater scripts easier.

> +      (propagated-inputs
> +       (list xclip xdotool xprop xwininfo))

Could you turn those into regular inputs, and patch calls in the
library? Ideally, upstream should turn the location of these executables
into a defcustom. You may want to suggest it to them.

Regards,
-- 
Nicolas Goaziou

Message #11 received at 53879 <at> debbugs.gnu.org (full text, mbox):

From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 53879 <at> debbugs.gnu.org
Subject: Re: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Wed, 09 Feb 2022 05:10:21 +0530

[Message part 1 (text/plain, inline)]

On 2022-02-08, 18:29 +0100, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:

>> +      (propagated-inputs
>> +       (list xclip xdotool xprop xwininfo))
>
> Could you turn those into regular inputs, and patch calls in the
> library? Ideally, upstream should turn the location of these
> executables into a defcustom. You may want to suggest it to them.

Could you please point out any package that does this, so that I could
better understand what you're talking about.

Thanks!

-- 
Jai Vetrivelan

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 53879 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Cc: 53879 <at> debbugs.gnu.org
Subject: Re: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Wed, 09 Feb 2022 00:44:30 +0100

Hello,

Jai Vetrivelan <jaivetrivelan <at> gmail.com> writes:

>> Could you turn those into regular inputs, and patch calls in the
>> library? Ideally, upstream should turn the location of these
>> executables into a defcustom. You may want to suggest it to them.
>
> Could you please point out any package that does this, so that I could
> better understand what you're talking about.

Certainly. See, for example, `patch-exec-paths' phase in emacs-theme-magic.

Regards,
-- 
Nicolas Goaziou

Message #17 received at 53879 <at> debbugs.gnu.org (full text, mbox):

From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 53879 <at> debbugs.gnu.org
Subject: Re: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Wed, 09 Feb 2022 06:21:14 +0530

[0001-gnu-Add-emacs-everywhere.patch (text/x-patch, inline)]

From baf437b34b900ba1733657e560187807c7a67007 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Date: Tue, 8 Feb 2022 20:44:05 +0530
Subject: [PATCH] gnu: Add emacs-everywhere.

* gnu/packages/emacs-xyz.scm (emacs-everywhere): New variable.
---
 gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 56af72b2ab..e68877ee30 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26279,6 +26279,49 @@ (define-public emacs-evil-tmux-navigator
 Emacs windows and tmux panes.")
     (license license:expat)))
 
+(define-public emacs-everywhere
+  ;; No upstream release.  Extract version from main file.
+  (let ((commit "ace53396a66ed4b753f42c04a5a0db2bcd770423")
+        (revision "0"))
+    (package
+      (name "emacs-everywhere")
+      (version (git-version "0.0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/tecosaur/emacs-everywhere")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0p55shxvqm1713af33mfglny7rpi31d42wvgwylcsfy4jvnsq8bb"))))
+      (arguments
+       `(#:phases (modify-phases %standard-phases
+                    (add-after 'unpack 'patch-exec-paths
+                      (lambda* (#:key inputs #:allow-other-keys)
+                        (let ((xclip (assoc-ref inputs "xclip"))
+                              (xdotool (assoc-ref inputs "xdotool"))
+                              (xprop (assoc-ref inputs "xprop"))
+                              (xwininfo (assoc-ref inputs "xwininfo")))
+                          (substitute* "emacs-everywhere.el"
+                            (("\"xclip\"") (string-append "\"" xclip
+                                                          "/bin/xclip\""))
+                            (("\"xdotool\"") (string-append "\"" xdotool
+                                                            "/bin/xdotool\""))
+                            (("\"xprop\"") (string-append "\"" xprop
+                                                          "/bin/xprop\""))
+                            (("\"xwininfo\"") (string-append "\"" xwininfo
+                                                             "/bin/xwininfo\""))))
+                        #t)))))
+      (inputs (list xclip xdotool xprop xwininfo))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/tecosaur/emacs-everywhere")
+      (synopsis "System-wide popup Emacs windows for quick edits")
+      (description "@code{emacs-everywhere} launches a new Emacs frame, and the
+contents of the buffer are pasted into the previously focused application on
+deletion of the frame.")
+      (license license:gpl3+))))
+
 (define-public emacs-xclip
   (package
     (name "emacs-xclip")

base-commit: 35d56676db0988aad6d1a5b52dc4efef578885f2
-- 
2.34.0

Message #22 received at 53879-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Cc: 53879-done <at> debbugs.gnu.org
Subject: Re: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Wed, 09 Feb 2022 15:11:10 +0100

Hello,

Jai Vetrivelan <jaivetrivelan <at> gmail.com> writes:

Thanks for the update. I'm sorry: I pointed you, as an example, to
a package using old syntax.

> +(define-public emacs-everywhere
> +  ;; No upstream release.  Extract version from main file.
> +  (let ((commit "ace53396a66ed4b753f42c04a5a0db2bcd770423")
> +        (revision "0"))
> +    (package
> +      (name "emacs-everywhere")
> +      (version (git-version "0.0.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/tecosaur/emacs-everywhere")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0p55shxvqm1713af33mfglny7rpi31d42wvgwylcsfy4jvnsq8bb"))))
> +      (arguments
> +       `(#:phases (modify-phases %standard-phases

We're now using G-expressions, which are less ambiguous than quasi-quotes:

(arguments
 (list
  #:phases
  #~(modify-phases %standard-phases

> +                    (add-after 'unpack 'patch-exec-paths
> +                      (lambda* (#:key inputs #:allow-other-keys)
> +                        (let ((xclip (assoc-ref inputs "xclip"))
> +                              (xdotool (assoc-ref inputs "xdotool"))
> +                              (xprop (assoc-ref inputs "xprop"))
> +                              (xwininfo (assoc-ref inputs "xwininfo")))

We don't use (assoc-ref inputs ...) expressions anymore. It is possible
to replace those calls with `search-input-file'.

> +                          (substitute* "emacs-everywhere.el"
> +                            (("\"xclip\"") (string-append "\"" xclip
> +                                                          "/bin/xclip\""))

For example, here, it is possible to write

  (string-append "\"" (search-input-file inputs "/bin/xclip") "\"")

> +                        #t)))))

Phases do not need to end with "#t" anymore, so this can be dropped.

I made the changes above on your behalf and applied your patch.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.