GNU bug report logs - #53879
[PATCH] gnu: Add emacs-everywhere.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan <at> gmail.com>
Cc: 53879 <at> debbugs.gnu.org
Subject: [bug#53879] [PATCH] gnu: Add emacs-everywhere.
Date: Tue, 08 Feb 2022 18:29:27 +0100

Hello,

Jai Vetrivelan <jaivetrivelan <at> gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-everywhere.

Thanks. Some comments follow.

> +(define-public emacs-everywhere
> +  ;; No upstream release.  Extract version from main file.
> +  (let ((revision "0") (version "0.0.1")

Nitpick: binding should go to separate lines. However, in this case,
I suggest to move version string right in the "version" field. It will
make life of the updater scripts easier.

> +      (propagated-inputs
> +       (list xclip xdotool xprop xwininfo))

Could you turn those into regular inputs, and patch calls in the
library? Ideally, upstream should turn the location of these executables
into a defcustom. You may want to suggest it to them.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.