GNU bug report logs - #53878
[PATCH 00/11] Update Racket to 8.4. Adjust Chez Scheme

Previous Next

Package: guix-patches;

Reported by: Philip McGrath <philip <at> philipmcgrath.com>

Date: Tue, 8 Feb 2022 15:14:01 UTC

Severity: normal

Tags: patch

Merged with 53997

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #360 received at 53878 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Philip McGrath <philip.mcgrath <at> gmail.com>,
 Malte Gerdes <malte.f.gerdes <at> gmail.com>, Maxime Devos <maximedevos <at> telenet.be>,
 raingloom <raingloom <at> riseup.net>, Attila Lendvai <attila <at> lendvai.name>,
 Ludovic Courtès <ludo <at> gnu.org>, 53878 <at> debbugs.gnu.org,
 Philip McGrath <philip <at> philipmcgrath.com>
Subject: Re: [PATCH v3 09/15] gnu: Add racket-vm-cgc.
Date: Thu, 24 Feb 2022 16:09:21 +0100
Hi Liliana,

Thanks Philip for these large series.

> I know I have a tendency towards being overly cautious when it comes to
> pushing big changes, so if that's the case I'd be happy if someone else
> were to take over.  That said, I do feel somewhat lonely at the moment
> despite the many people specifically mentioned in "To:" and "Cc:", so
> I'm somewhat content with moving slowly for now.

Sorry, I am running out of time and the series is quite large; the
changes are not really atomic. ;-)


On Wed, 23 Feb 2022 at 21:31, Liliana Marie Prikler
<liliana.prikler <at> gmail.com> wrote:

> > But I am confident that v4 of this series is at least not broken, if
> > perhaps not maximally beautiful. Especially given that I, for one,
> > have tried things that initially seemed correct only to discover
> > subtle problems later, I think it would be better for any refinements
> > to come in follow-on patches later.
>
> I can understand the sentiment, but there are some things that still
> don't feel right for me – for instance the fact, that seemingly
> unrelated modules now have to pull in racket bootstrap sounds like a
> recipe for trouble.  The final patch in the series also still does too
> much for me to wrap my head around, which makes it difficult to audit.

I understand both sentiments.  I also have some difficulties for
auditing the series.  Well, it needs some time to sit down, fill the
coffee pot and careful review. :-)

I cannot promise but I will try to give a look next week; for what my
reviewing eyes are worth.

Cheers,
simon




This bug report was last modified 2 years and 344 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.