GNU bug report logs - #53868
[PATCH] gnu: clojure-data-xml: Fix test suite

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ryan Sundberg <ryan <at> arctype.co>
Subject: bug#53868: closed (Re: [bug#53868] [PATCH] gnu: clojure-data-xml:
 Fix test suite)
Date: Tue, 08 Feb 2022 10:54:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53868: [PATCH] gnu: clojure-data-xml: Fix test suite

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53868 <at> debbugs.gnu.org.

-- 
53868: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53868
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ryan Sundberg <ryan <at> arctype.co>, 53868-done <at> debbugs.gnu.org
Subject: Re: [bug#53868] [PATCH] gnu: clojure-data-xml: Fix test suite
Date: Tue, 8 Feb 2022 11:53:19 +0100

Le Mon,  7 Feb 2022 21:28:13 -0800,
Ryan Sundberg via Guix-patches via <guix-patches <at> gnu.org> a écrit :

> Removes clojurescript related tests that interfere with the JDK
> clojure test suite, causing it to fail.
> 
> * gnu/packages/clojure.scm (clojure-data-xml)[arguments]: Add
> 'delete-cljs-tests phase
> ---
>  gnu/packages/clojure.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 2a9ad90740..3ee4941ddb 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -441,8 +441,14 @@ (define-public clojure-data-xml
>      (build-system clojure-build-system)
>      (arguments
>       '(#:source-dirs '("src/main/clojure")
> -       #:test-dirs '("src/test/clojure")
> -       #:doc-dirs '()))
> +       #:test-dirs '("src/test/clojure" "src/test/resources")
> +       #:doc-dirs '()
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'delete-cljs-tests
> +                     (lambda _
> +                       (delete-file
> "src/test/resources/clojure/data/xml/cljs_testsuite.clj")
> +                       (delete-file
> "src/test/clojure/clojure/data/xml/test_cljs.clj"))))))
> (propagated-inputs (list clojure-data-codec)) (synopsis "Clojure
> library for reading and writing XML data") (description
> "@code{data.xml} is a Clojure library for reading and writing

Thanks for the patch, pushed to master as
6d357541021578914eba7bb33d2529a6744de36d.

[Message part 3 (message/rfc822, inline)]

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] gnu: clojure-data-xml: Fix test suite
Date: Mon,  7 Feb 2022 21:28:13 -0800

Removes clojurescript related tests that interfere with the JDK clojure
test suite, causing it to fail.

* gnu/packages/clojure.scm (clojure-data-xml)[arguments]: Add
'delete-cljs-tests phase
---
 gnu/packages/clojure.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 2a9ad90740..3ee4941ddb 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -441,8 +441,14 @@ (define-public clojure-data-xml
     (build-system clojure-build-system)
     (arguments
      '(#:source-dirs '("src/main/clojure")
-       #:test-dirs '("src/test/clojure")
-       #:doc-dirs '()))
+       #:test-dirs '("src/test/clojure" "src/test/resources")
+       #:doc-dirs '()
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'delete-cljs-tests
+                     (lambda _
+                       (delete-file "src/test/resources/clojure/data/xml/cljs_testsuite.clj")
+                       (delete-file "src/test/clojure/clojure/data/xml/test_cljs.clj"))))))
     (propagated-inputs (list clojure-data-codec))
     (synopsis "Clojure library for reading and writing XML data")
     (description "@code{data.xml} is a Clojure library for reading and writing
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.