GNU bug report logs - #53868
[PATCH] gnu: clojure-data-xml: Fix test suite

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53868 in the body.
You can then email your comments to 53868 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] gnu: clojure-data-xml: Fix test suite
Date: Mon,  7 Feb 2022 21:28:13 -0800

Removes clojurescript related tests that interfere with the JDK clojure
test suite, causing it to fail.

* gnu/packages/clojure.scm (clojure-data-xml)[arguments]: Add
'delete-cljs-tests phase
---
 gnu/packages/clojure.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 2a9ad90740..3ee4941ddb 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -441,8 +441,14 @@ (define-public clojure-data-xml
     (build-system clojure-build-system)
     (arguments
      '(#:source-dirs '("src/main/clojure")
-       #:test-dirs '("src/test/clojure")
-       #:doc-dirs '()))
+       #:test-dirs '("src/test/clojure" "src/test/resources")
+       #:doc-dirs '()
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'delete-cljs-tests
+                     (lambda _
+                       (delete-file "src/test/resources/clojure/data/xml/cljs_testsuite.clj")
+                       (delete-file "src/test/clojure/clojure/data/xml/test_cljs.clj"))))))
     (propagated-inputs (list clojure-data-codec))
     (synopsis "Clojure library for reading and writing XML data")
     (description "@code{data.xml} is a Clojure library for reading and writing
-- 
2.34.0

Message #8 received at 53868 <at> debbugs.gnu.org (full text, mbox):

From: ryan <at> arctype.co
To: 53868 <at> debbugs.gnu.org
Subject: Duplicate of bug 53860
Date: Mon, 07 Feb 2022 21:48:32 -0800

This patch is a duplicate of 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53860
with a different approach that only disables the specific failing tests.

Message #13 received at 53868-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
Cc: Ryan Sundberg <ryan <at> arctype.co>, 53868-done <at> debbugs.gnu.org
Subject: Re: [bug#53868] [PATCH] gnu: clojure-data-xml: Fix test suite
Date: Tue, 8 Feb 2022 11:53:19 +0100

Le Mon,  7 Feb 2022 21:28:13 -0800,
Ryan Sundberg via Guix-patches via <guix-patches <at> gnu.org> a écrit :

> Removes clojurescript related tests that interfere with the JDK
> clojure test suite, causing it to fail.
> 
> * gnu/packages/clojure.scm (clojure-data-xml)[arguments]: Add
> 'delete-cljs-tests phase
> ---
>  gnu/packages/clojure.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 2a9ad90740..3ee4941ddb 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -441,8 +441,14 @@ (define-public clojure-data-xml
>      (build-system clojure-build-system)
>      (arguments
>       '(#:source-dirs '("src/main/clojure")
> -       #:test-dirs '("src/test/clojure")
> -       #:doc-dirs '()))
> +       #:test-dirs '("src/test/clojure" "src/test/resources")
> +       #:doc-dirs '()
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'delete-cljs-tests
> +                     (lambda _
> +                       (delete-file
> "src/test/resources/clojure/data/xml/cljs_testsuite.clj")
> +                       (delete-file
> "src/test/clojure/clojure/data/xml/test_cljs.clj"))))))
> (propagated-inputs (list clojure-data-codec)) (synopsis "Clojure
> library for reading and writing XML data") (description
> "@code{data.xml} is a Clojure library for reading and writing

Thanks for the patch, pushed to master as
6d357541021578914eba7bb33d2529a6744de36d.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.