GNU bug report logs - #53860
[PATCH] gnu: clojure-data-xml: Fix build by removing tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53860 in the body.
You can then email your comments to 53860 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: guix-patches <at> gnu.org
Cc: Steve George <steve <at> futurile.net>
Subject: [PATCH] gnu: clojure-data-xml: Fix build by removing tests.
Date: Mon,  7 Feb 2022 19:32:19 +0000

* gnu/packages/clojure.scm (clojure-data-xml): tests don't work with stable and
recent versions of the JDK (https://clojure.atlassian.net/browse/DXML-67).
Prevent test build stage running.
---
 gnu/packages/clojure.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 40a3d7708a..6f9dbd6bca 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -333,10 +333,13 @@ is on par with Java implementations, e.g., Apache commons-codec.")
     (arguments
      '(#:source-dirs '("src/main/clojure")
        #:test-dirs '("src/test/clojure")
-       #:doc-dirs '()))
+       #:doc-dirs '()
+       ;; FIXME: resolve when https://clojure.atlassian.net/browse/DXML-67 is closed
+       #:tests? #f))
     (propagated-inputs (list clojure-data-codec))
     (synopsis "Clojure library for reading and writing XML data")
-    (description "@code{data.xml} is a Clojure library for reading and writing
+    (description
+     "@code{data.xml} is a Clojure library for reading and writing
 XML data. @code{data.xml} has the following features:
 
 Parses XML documents into Clojure data structures

base-commit: abb197dfe98095a9ea7527a3ca3f81bb0edd5813
-- 
2.17.1

Message #12 received at 53860-close <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Steve George <steve <at> futurile.net>
Cc: 53860-close <at> debbugs.gnu.org
Subject: Re: [bug#53860] [PATCH] gnu: clojure-data-xml: Fix build by
 removing tests.
Date: Tue, 8 Feb 2022 11:55:49 +0100

Le Mon,  7 Feb 2022 19:32:19 +0000,
Steve George <steve <at> futurile.net> a écrit :

> * gnu/packages/clojure.scm (clojure-data-xml): tests don't work with
> stable and recent versions of the JDK
> (https://clojure.atlassian.net/browse/DXML-67). Prevent test build
> stage running. ---
>  gnu/packages/clojure.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 40a3d7708a..6f9dbd6bca 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -333,10 +333,13 @@ is on par with Java implementations, e.g.,
> Apache commons-codec.") (arguments
>       '(#:source-dirs '("src/main/clojure")
>         #:test-dirs '("src/test/clojure")
> -       #:doc-dirs '()))
> +       #:doc-dirs '()
> +       ;; FIXME: resolve when
> https://clojure.atlassian.net/browse/DXML-67 is closed
> +       #:tests? #f))
>      (propagated-inputs (list clojure-data-codec))
>      (synopsis "Clojure library for reading and writing XML data")
> -    (description "@code{data.xml} is a Clojure library for reading
> and writing
> +    (description
> +     "@code{data.xml} is a Clojure library for reading and writing
>  XML data. @code{data.xml} has the following features:
>  
>  Parses XML documents into Clojure data structures
> 
> base-commit: abb197dfe98095a9ea7527a3ca3f81bb0edd5813

Thanks for the patch! Ryan had a better approach in
https://issues.guix.gnu.org/53868, so I pushed it instead. Disabling
only the failing test is better that disabling all tests :).

Closing this as the package is now fixed. Thanks!

Message #20 received at 53860 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 53860 <at> debbugs.gnu.org
Date: Tue, 8 Feb 2022 11:03:03 +0000

See #53868 which is better as it only stops cljs tests. 
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53868)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.