GNU bug report logs - #53821
[PATCH] Add the python-psycopg2-binary package.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53821 in the body.
You can then email your comments to 53821 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre-Henry Fröhring <contact <at> phfrohring.com>
To: guix-patches <at> gnu.org
Cc: Pierre-Henry Fröhring <contact <at> phfrohring.com>
Subject: [PATCH] Add the python-psycopg2-binary package.
Date: Sun,  6 Feb 2022 15:38:14 +0100

`(#:tests? #f)' because tests require a live PostegreSQL instance.
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7c1b5e8ed3..a136de9990 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -28931,3 +28931,39 @@ (define-public python-types-dataclasses
      "This packages provides a collection of library stubs for Python, with
 static types.")
     (license license:asl2.0)))
+
+(define-public python-psycopg2-binary
+  (package
+    (name "python-psycopg2-binary")
+    (version "2.9.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "psycopg2-binary" version))
+              (sha256
+               (base32
+                "0kpaxg3lg5wg5ww5kxmzi2z2d7arsx13ci915d8a2pf17lqza7bn"))))
+    (build-system python-build-system)
+    (native-inputs (list postgresql))
+    (arguments
+     '(#:tests? #f))
+    (home-page "https://psycopg.org/")
+    (synopsis "Python-PostgreSQL Database Adapter")
+    (description
+     "Psycopg is the most popular PostgreSQL database
+adapter for the Python programming language.  Its main features are the
+complete implementation of the Python DB API 2.0 specification and the
+thread safety (several threads can share the same connection).  It was
+designed for heavily multi-threaded applications that create and
+destroy lots of cursors and make a large number of concurrent
+“INSERT”s or “UPDATE”s.
+
+Psycopg 2 is mostly implemented in C as a libpq wrapper, resulting in
+being both efficient and secure.  It features client-side and
+server-side cursors, asynchronous communication and notifications,
+“COPY TO/COPY FROM” support.  Many Python types are supported
+out-of-the-box and adapted to matching PostgreSQL data types;
+adaptation can be extended and customized thanks to a flexible objects
+adaptation system.
+
+Psycopg 2 is both Unicode and Python 3 friendly.")
+    (license license:lgpl3+)))
-- 
2.34.0

Message #8 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Pierre-Henry Fröhring <contact <at> phfrohring.com>, 
 53821 <at> debbugs.gnu.org
Subject: Re: [bug#53821] [PATCH] Add the python-psycopg2-binary package.
Date: Sun, 06 Feb 2022 15:50:47 +0100

[Message part 1 (text/plain, inline)]

Pierre-Henry Fröhring schreef op zo 06-02-2022 om 15:38 [+0100]:
> +     "Psycopg is the most popular [...]
> +
> +[...], resulting in being both efficient and secure.
> 

From (guix)Synopses and Descriptions:

Please avoid marketing phrases such as “world-leading”,
“industrial-strength”, and “next-generation”, and avoid superlatives
like “the most advanced”—they are not helpful to users looking for a
package and may even sound suspicious.  Instead, try to be factual,
mentioning use cases and features.

Here, ‘most popular’ would could as marketing (it isn't important
whether it's popular, what is important is that it works well),
and to a lesser degree ‘efficient and secure’ -- everything is
supposed to be efficient and secure (with varying success).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Pierre-Henry Fröhring <contact <at> phfrohring.com>, 
 53821 <at> debbugs.gnu.org
Subject: Re: [bug#53821] [PATCH] Add the python-psycopg2-binary package.
Date: Sun, 06 Feb 2022 15:51:56 +0100

[Message part 1 (text/plain, inline)]

Pierre-Henry Fröhring schreef op zo 06-02-2022 om 15:38 [+0100]:
> `(#:tests? #f)' because tests require a live PostegreSQL instance.
> ---
>  gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)

This needs to be documented ...

> +    (arguments
> +     '(#:tests? #f))

... here, as a comment, to aid future readers, and to avoid
accidentally teaching people to just disable tests.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: Pierre-Henry Fröhring <contact <at> phfrohring.com>
To: Maxime Devos <maximedevos <at> telenet.be>, 53821 <at> debbugs.gnu.org
Subject: Re: [bug#53821] [PATCH] Add the python-psycopg2-binary package.
Date: Sun, 06 Feb 2022 16:27:33 +0100

Hello Maxime,

I've just copy-pasted the author's description as in:

  https://pypi.org/project/psycopg2-binary/

So, if I understand correctly, package contributors should (re)write
packages descriptions?

PHF

On Sun, 2022-02-06 at 15:50 +0100, Maxime Devos wrote:
> Pierre-Henry Fröhring schreef op zo 06-02-2022 om 15:38 [+0100]:
> > +     "Psycopg is the most popular [...]
> > +
> > +[...], resulting in being both efficient and secure.
> > 
> 
> From (guix)Synopses and Descriptions:
> 
> Please avoid marketing phrases such as “world-leading”,
> “industrial-strength”, and “next-generation”, and avoid superlatives
> like “the most advanced”—they are not helpful to users looking for a
> package and may even sound suspicious.  Instead, try to be factual,
> mentioning use cases and features.
> 
> Here, ‘most popular’ would could as marketing (it isn't important
> whether it's popular, what is important is that it works well),
> and to a lesser degree ‘efficient and secure’ -- everything is
> supposed to be efficient and secure (with varying success).
> 
> Greetings,
> Maxime.

Message #17 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: Pierre-Henry Fröhring <contact <at> phfrohring.com>
To: 53821 <at> debbugs.gnu.org
Cc: Pierre-Henry Fröhring <contact <at> phfrohring.com>
Subject: [PATCH] Add the python-psycopg2-binary package.
Date: Sun,  6 Feb 2022 16:35:56 +0100

`(#:tests? #f)' because tests require a live PostegreSQL instance.

Maxime's suggestions are taken into account in this patch:
  - `(#:tests? #f)' is commented in the code
  - superlatives in the description have been removed
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7c1b5e8ed3..7b2df04fd2 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -28931,4 +28931,39 @@ (define-public python-types-dataclasses
      "This packages provides a collection of library stubs for Python, with
 static types.")
     (license license:asl2.0)))
+
+(define-public python-psycopg2-binary
+  (package
+    (name "python-psycopg2-binary")
+    (version "2.9.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "psycopg2-binary" version))
+              (sha256
+               (base32
+                "0kpaxg3lg5wg5ww5kxmzi2z2d7arsx13ci915d8a2pf17lqza7bn"))))
+    (build-system python-build-system)
+    (native-inputs (list postgresql))
+    (arguments
+     ;; Tests are disable because they need a live instance of PostgreSQL.
+     '(#:tests? #f))
+    (home-page "https://psycopg.org/")
+    (synopsis "Python-PostgreSQL Database Adapter")
+    (description
+     "Psycopg is a PostgreSQL database adapter for the Python programming
+language.  Its main features are the complete implementation of the Python DB
+API 2.0 specification and the thread safety (several threads can share the
+same connection).  It was designed for heavily multi-threaded applications
+that create and destroy lots of cursors and make a large number of concurrent
+“INSERT”s or “UPDATE”s.
+
+Psycopg 2 is mostly implemented in C as a libpq wrapper, resulting in
+being both efficient and secure.  It features client-side and
+server-side cursors, asynchronous communication and notifications,
+“COPY TO/COPY FROM” support.  Many Python types are supported
+out-of-the-box and adapted to matching PostgreSQL data types;
+adaptation can be extended and customized thanks to a flexible objects
+adaptation system.
+
+Psycopg 2 is both Unicode and Python 3 friendly.")
+    (license license:lgpl3+)))
--
2.34.0

Message #20 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Pierre-Henry Fröhring <contact <at> phfrohring.com>, 
 53821 <at> debbugs.gnu.org
Subject: Re: [bug#53821] [PATCH] Add the python-psycopg2-binary package.
Date: Sun, 06 Feb 2022 16:44:34 +0100

[Message part 1 (text/plain, inline)]

Pierre-Henry Fröhring schreef op zo 06-02-2022 om 16:27 [+0100]:
> Hello Maxime,
> 
> I've just copy-pasted the author's description as in:
> 
>   https://pypi.org/project/psycopg2-binary/
> 
> So, if I understand correctly, package contributors should (re)write
> packages descriptions?

Yes, package descriptions from upstream are useful but may need to
be rewritten a bit.

Also, for whatever reason, people seem to always ignore the copyright
and license on upstream's description, but I don't understand how this
would be justified legally.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 53821-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre-Henry Fröhring <contact <at> phfrohring.com>
Cc: 53821-done <at> debbugs.gnu.org
Subject: Re: bug#53821: [PATCH] Add the python-psycopg2-binary package.
Date: Thu, 24 Mar 2022 23:23:40 +0100

Hi,

Pierre-Henry Fröhring <contact <at> phfrohring.com> skribis:

> `(#:tests? #f)' because tests require a live PostegreSQL instance.
>
> Maxime's suggestions are taken into account in this patch:
>   - `(#:tests? #f)' is commented in the code
>   - superlatives in the description have been removed
> ---
>  gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 7c1b5e8ed3..7b2df04fd2 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -28931,4 +28931,39 @@ (define-public python-types-dataclasses
>       "This packages provides a collection of library stubs for Python, with
>  static types.")
>      (license license:asl2.0)))
> +
> +(define-public python-psycopg2-binary

Applied with minor tweaks to the synopsis and description and a commit
log that follows our conventions:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

Thanks, and thank you Maxime!

Ludo’.

Message #32 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 53821 <at> debbugs.gnu.org
Cc: Pierre-Henry Fröhring <contact <at> phfrohring.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] Add the python-psycopg2-binary package.
Date: Sun, 02 Feb 2025 23:49:44 +0000

[Message part 1 (text/plain, inline)]

> Don't see any difference, which is just weird.

Interesting...

Should we remove it?

all best,

jgart

[Message part 2 (text/html, inline)]

Message #35 received at 53821 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 53821 <at> debbugs.gnu.org
Cc: Pierre-Henry Fröhring <contact <at> phfrohring.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] Add the python-psycopg2-binary package.
Date: Wed, 5 Feb 2025 19:15:00 +0100

[Message part 1 (text/plain, inline)]

(including previous reply after unarchiving)

On 17/01/2025 5:50, jgart wrote:
> Isn't python-psycopg2-binary just a pre-built binary of python-pyscopg2
> distributed on PyPI IIRC?

I now looked at the most recent pypi tar to check this 
(https://files.pythonhosted.org/packages/cb/0e/bdc8274dc0585090b4e3432267d7be4dfbfd8971c0fa59167c711105a6bf/psycopg2-binary-2.9.10.tar.gz), 
and compared it (manually) to the python-psycopg2 tar.

Don't see any difference, which is just weird.

Recommend 'diffoscope [psycopg2 source] [pysocopg2-binary 'source']' for 
a closer investigation.

(---)

On 3/02/2025 0:49, jgart wrote:

> > Don't see any difference, which is just weird.
>
> Interesting...
>
> Should we remove it?

I think it's important to mention here that the computer I'm writing 
this on, doesn't have Guix and in particular it doesn't have diffoscope, 
so I cannot practically answer that at this time.

Best regards,
Maxime Devos

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.