GNU bug report logs - #53820
[PATCH] gnu: Add jtdx

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53820 in the body.
You can then email your comments to 53820 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Sheng Yang" <styang <at> fastmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add jtdx
Date: Sun, 06 Feb 2022 08:14:26 -0600

[Message part 1 (text/plain, inline)]

JTDX is a popular fork of WSJT-X, commonly used by ham radio operators for FT8 and other modes.

This is the first time I am submitting a patch to Guix. I have tried my best to format and test it, with the help of a few friends familiar with Guix. Feel free to modify the patch if I did something incorrectly.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-jtdx.patch (text/x-patch, attachment)]

Message #8 received at 53820 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Sheng Yang <styang <at> fastmail.com>, 53820 <at> debbugs.gnu.org
Subject: Re: [bug#53820] [PATCH] gnu: Add jtdx
Date: Sun, 06 Feb 2022 15:56:55 +0100

[Message part 1 (text/plain, inline)]

Sheng Yang schreef op zo 06-02-2022 om 08:14 [-0600]:
> +             (url "https://github.com/Hamlib/Hamlib.git")

That looks like a location of upstream to me, not the fork.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 53820 <at> debbugs.gnu.org (full text, mbox):

From: "Sheng Yang" <styang <at> fastmail.com>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 53820 <at> debbugs.gnu.org
Subject: Re: [bug#53820] [PATCH] gnu: Add jtdx
Date: Sun, 06 Feb 2022 09:02:31 -0600

[Message part 1 (text/plain, inline)]

My fault. I somehow misunderstood the lines in the release note.
> JTDX 2.2.158 builds made with modified Hamlib, based on Hamlib commit https://github.com/Hamlib/Hamlib/commit/954d70c143a9a0293371d8def3a7300ce3ca68c4 as of December 30th, 2021

Found the true location of their fork of hamlib (https://github.com/jtdx-project/jtdxhamlib). Will update the patch when I managed to pack it.

On Sun, Feb 6, 2022, at 08:56, Maxime Devos wrote:
> Sheng Yang schreef op zo 06-02-2022 om 08:14 [-0600]:
> > +             (url "https://github.com/Hamlib/Hamlib.git")
> 
> That looks like a location of upstream to me, not the fork.
> 
> Greetings,
> Maxime.
> 
> 
> *Attachments:*
>  * signature.asc

[Message part 2 (text/html, inline)]

Message #14 received at 53820 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Sheng Yang <styang <at> fastmail.com>, 53820 <at> debbugs.gnu.org
Subject: Re: [bug#53820] [PATCH] gnu: Add jtdx
Date: Sun, 06 Feb 2022 16:05:21 +0100

[Message part 1 (text/plain, inline)]

Sheng Yang schreef op zo 06-02-2022 om 08:14 [-0600]:
> +(define jtdx-hamlib
> +  ;; Fork of hamlib with custom patches used by jtdx.

Have these patches been submitted upstream?  If so, can we
add a link to a web page tracking upstreaming progress,
such that we can determine when 'jdtx-hamlib' can be removed
in favour of 'hamlib'?

Given that it is a fork, doesn't the home page, synopsis and
description need to be tweaked?

Why define and not define-public?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 53820 <at> debbugs.gnu.org (full text, mbox):

From: "Sheng Yang" <styang <at> fastmail.com>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 53820 <at> debbugs.gnu.org
Subject: Re: [bug#53820] [PATCH] gnu: Add jtdx
Date: Sun, 06 Feb 2022 09:20:51 -0600

[Message part 1 (text/plain, inline)]

> Have these patches been submitted upstream?  If so, can we
> add a link to a web page tracking upstreaming progress,
> such that we can determine when 'jdtx-hamlib' can be removed
> in favour of 'hamlib'?
I don't think those patches are submitted upstream. I checked diff between jtdx-hamlib's master with commit 954d70c143a9a0293371d8def3a7300ce3ca68c4 <https://github.com/Hamlib/Hamlib/commit/954d70c143a9a0293371d8def3a7300ce3ca68c4>, which has quite some differences. I am not a developer of either package, so I cannot tell which one/ones is necessary. As it turns out, the configure options seem a lot different from the official one. The following is in the README of jtdx-hamlib:
> $ ../src/configure --prefix=$HOME/hamlib-prefix 
> --disable-shared --enable-static 
> --without-cxx-binding --disable-winradio 
> CFLAGS="-g -O2 -fdata-sections -ffunction-sections" 
> LDFLAGS="-Wl,--gc-sections" 
While in hamlib and wsjtx-hamlib, the build configuration is:
> (arguments
>      `(#:configure-flags '("--disable-static"
>                            "--with-lua-binding"
>                            "--with-python-binding"
>                            "--with-tcl-binding"
>                            "--with-xml-support")))

> Given that it is a fork, doesn't the home page, synopsis and
> description need to be tweaked?
> 
> Why define and not define-public?
I basically followed the existing package wsjtx-hamlib.

[Message part 2 (text/html, inline)]

Message #20 received at 53820 <at> debbugs.gnu.org (full text, mbox):

From: "Sheng Yang" <styang <at> fastmail.com>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 53820 <at> debbugs.gnu.org
Subject: Re: [bug#53820] [PATCH] gnu: Add jtdx
Date: Sun, 06 Feb 2022 10:22:52 -0600

[Message part 1 (text/plain, inline)]

Patch updated.

On Sun, Feb 6, 2022, at 09:20, Sheng Yang wrote:
>> Have these patches been submitted upstream?  If so, can we
>> add a link to a web page tracking upstreaming progress,
>> such that we can determine when 'jdtx-hamlib' can be removed
>> in favour of 'hamlib'?
> I don't think those patches are submitted upstream. I checked diff between jtdx-hamlib's master with commit 954d70c143a9a0293371d8def3a7300ce3ca68c4 <https://github.com/Hamlib/Hamlib/commit/954d70c143a9a0293371d8def3a7300ce3ca68c4>, which has quite some differences. I am not a developer of either package, so I cannot tell which one/ones is necessary. As it turns out, the configure options seem a lot different from the official one. The following is in the README of jtdx-hamlib:
>> $ ../src/configure --prefix=$HOME/hamlib-prefix 
>> --disable-shared --enable-static 
>> --without-cxx-binding --disable-winradio 
>> CFLAGS="-g -O2 -fdata-sections -ffunction-sections" 
>> LDFLAGS="-Wl,--gc-sections" 
> While in hamlib and wsjtx-hamlib, the build configuration is:
>> (arguments
>>      `(#:configure-flags '("--disable-static"
>>                            "--with-lua-binding"
>>                            "--with-python-binding"
>>                            "--with-tcl-binding"
>>                            "--with-xml-support")))
> 
>> Given that it is a fork, doesn't the home page, synopsis and
>> description need to be tweaked?
>> 
>> Why define and not define-public?
> I basically followed the existing package wsjtx-hamlib.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-jtdx.patch (text/x-patch, attachment)]

Message #25 received at 53820-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Sheng Yang" <styang <at> fastmail.com>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 53820-done <at> debbugs.gnu.org
Subject: Re: bug#53820: [PATCH] gnu: Add jtdx
Date: Sun, 06 Mar 2022 22:36:23 +0100

Hi,

"Sheng Yang" <styang <at> fastmail.com> skribis:

> From 4a57cd007013a8bbade90dceccba4ec85207857f Mon Sep 17 00:00:00 2001
> From: Sheng Yang <yangsheng6810 <at> gmail.com>
> Date: Sun, 23 Jan 2022 21:46:27 -0600
> Subject: [PATCH] gnu: Add jtdx
>
> * gnu/packages/radio.scm (jtdx-hamlib): New variable.
>   (jtdx): New variable.

Applied.

Thank you, and thanks Maxime!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.