GNU bug report logs - #53812
[PATCH] gnu: Add emacs-mct.

Previous Next

Full log

Message #8 received at 53812 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 53812 <at> debbugs.gnu.org, Protesilaos Stavrou <public <at> protesilaos.com>
Subject: Re: [bug#53812] [PATCH] gnu: Add emacs-mct.
Date: Sun, 06 Feb 2022 22:51:28 +0100

Hello,

Andrew Tropin <andrew <at> trop.in> writes:

> * gnu/packages/emacs-xyz.scm (emacs-mct): New variable.

Thank you.

> +(define-public emacs-mct
> +  (package
> +   (name "emacs-mct")
> +   (version "0.4.2")
> +   (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                  (url "https://gitlab.com/protesilaos/mct.git")
> +                  (commit version)))
> +            (sha256
> +             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
> +            (file-name (git-file-name name version))))
> +   (build-system emacs-build-system)
> +   (license license:gpl3+)
> +   (home-page "https://protesilaos.com/emacs/mct")
> +   (synopsis "Enhancement of the default Emacs minibuffer completion UI.")

Synopsis may not end with a period. You may want to run "guix lint" on
your package definition.

> +   (description "Minibuffer and Completions in Tandem, also known as
> +mct, or mct.el, is a package that enhances the default minibuffer and
> +*Completions* buffer of Emacs 27 (or higher) so that they work
> +together as part of a unified framework. The idea is to make the
> +presentation and overall functionality be consistent with other
> +popular, vertically aligned completion UIs while leveraging built-in
> +functionality.")))

Sentences in description should be separated with two spaces.

Nitpick: license field usually comes last.

Note that upstream mentions this is an Emacs 28+ package, and Guix
provides only Emacs 27.2. Would it be a bit early to provide this
package?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.