GNU bug report logs - #53812
[PATCH] gnu: Add emacs-mct.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53812 in the body.
You can then email your comments to 53812 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Cc: Protesilaos Stavrou <public <at> protesilaos.com>
Subject: [PATCH] gnu: Add emacs-mct.
Date: Sat, 5 Feb 2022 20:19:52 +0300

[Message part 1 (text/plain, inline)]

* gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 444b761116..3e4ea925e1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30090,3 +30090,27 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-mct
+  (package
+   (name "emacs-mct")
+   (version "0.4.2")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://gitlab.com/protesilaos/mct.git")
+                  (commit version)))
+            (sha256
+             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
+            (file-name (git-file-name name version))))
+   (build-system emacs-build-system)
+   (license license:gpl3+)
+   (home-page "https://protesilaos.com/emacs/mct")
+   (synopsis "Enhancement of the default Emacs minibuffer completion UI.")
+   (description "Minibuffer and Completions in Tandem, also known as
+mct, or mct.el, is a package that enhances the default minibuffer and
+*Completions* buffer of Emacs 27 (or higher) so that they work
+together as part of a unified framework. The idea is to make the
+presentation and overall functionality be consistent with other
+popular, vertically aligned completion UIs while leveraging built-in
+functionality.")))
-- 
2.34.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 53812 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 53812 <at> debbugs.gnu.org, Protesilaos Stavrou <public <at> protesilaos.com>
Subject: Re: [bug#53812] [PATCH] gnu: Add emacs-mct.
Date: Sun, 06 Feb 2022 22:51:28 +0100

Hello,

Andrew Tropin <andrew <at> trop.in> writes:

> * gnu/packages/emacs-xyz.scm (emacs-mct): New variable.

Thank you.

> +(define-public emacs-mct
> +  (package
> +   (name "emacs-mct")
> +   (version "0.4.2")
> +   (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                  (url "https://gitlab.com/protesilaos/mct.git")
> +                  (commit version)))
> +            (sha256
> +             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
> +            (file-name (git-file-name name version))))
> +   (build-system emacs-build-system)
> +   (license license:gpl3+)
> +   (home-page "https://protesilaos.com/emacs/mct")
> +   (synopsis "Enhancement of the default Emacs minibuffer completion UI.")

Synopsis may not end with a period. You may want to run "guix lint" on
your package definition.

> +   (description "Minibuffer and Completions in Tandem, also known as
> +mct, or mct.el, is a package that enhances the default minibuffer and
> +*Completions* buffer of Emacs 27 (or higher) so that they work
> +together as part of a unified framework. The idea is to make the
> +presentation and overall functionality be consistent with other
> +popular, vertically aligned completion UIs while leveraging built-in
> +functionality.")))

Sentences in description should be separated with two spaces.

Nitpick: license field usually comes last.

Note that upstream mentions this is an Emacs 28+ package, and Guix
provides only Emacs 27.2. Would it be a bit early to provide this
package?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 53812 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <public <at> protesilaos.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, Andrew Tropin <andrew <at> trop.in>
Cc: 53812 <at> debbugs.gnu.org
Subject: Re: [bug#53812] [PATCH] gnu: Add emacs-mct.
Date: Mon, 07 Feb 2022 06:21:20 +0200

Hello Nicolas!

On 2022-02-06, 22:51 +0100, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:

> Note that upstream mentions this is an Emacs 28+ package, and Guix
> provides only Emacs 27.2. Would it be a bit early to provide this
> package?

This used to be the case in earlier versions, though mct.el specifies
the following since its version 0.3.0:

    ;; Package-Requires: ((emacs "27.1"))

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #14 received at 53812 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 53812 <at> debbugs.gnu.org, Protesilaos Stavrou <public <at> protesilaos.com>
Subject: Re: [bug#53812] [PATCH] gnu: Add emacs-mct.
Date: Mon, 07 Feb 2022 18:04:26 +0300

[Message part 1 (text/plain, inline)]

On 2022-02-06 22:51, Nicolas Goaziou wrote:

> Hello,
>
> Andrew Tropin <andrew <at> trop.in> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
>
> Thank you.
>
>> +(define-public emacs-mct
>> +  (package
>> +   (name "emacs-mct")
>> +   (version "0.4.2")
>> +   (source (origin
>> +            (method git-fetch)
>> +            (uri (git-reference
>> +                  (url "https://gitlab.com/protesilaos/mct.git")
>> +                  (commit version)))
>> +            (sha256
>> +             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
>> +            (file-name (git-file-name name version))))
>> +   (build-system emacs-build-system)
>> +   (license license:gpl3+)
>> +   (home-page "https://protesilaos.com/emacs/mct")
>> +   (synopsis "Enhancement of the default Emacs minibuffer completion UI.")
>
> Synopsis may not end with a period. You may want to run "guix lint" on
> your package definition.
>
>> +   (description "Minibuffer and Completions in Tandem, also known as
>> +mct, or mct.el, is a package that enhances the default minibuffer and
>> +*Completions* buffer of Emacs 27 (or higher) so that they work
>> +together as part of a unified framework. The idea is to make the
>> +presentation and overall functionality be consistent with other
>> +popular, vertically aligned completion UIs while leveraging built-in
>> +functionality.")))
>
> Sentences in description should be separated with two spaces.
>
> Nitpick: license field usually comes last.
>
> Note that upstream mentions this is an Emacs 28+ package, and Guix
> provides only Emacs 27.2. Would it be a bit early to provide this
> package?
>
> Regards,

Attaching v2, seems all the issues and questions are addressed.

[v2-0001-gnu-Add-emacs-mct.patch (text/x-patch, inline)]

From b4878a8adcbae7dd988df4741a39b0e0c27fb92b Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew <at> trop.in>
Date: Sat, 5 Feb 2022 20:19:52 +0300
Subject: [PATCH v2] gnu: Add emacs-mct.

* gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 444b761116..d7faf6ea6f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30090,3 +30090,26 @@ (define-public emacs-fennel-mode
      "Fennel mode provides font-lock, indentation, navigation, and REPL for
  Fennel code within Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-mct
+  (package
+   (name "emacs-mct")
+   (version "0.4.2")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://gitlab.com/protesilaos/mct.git")
+                  (commit version)))
+            (sha256
+             (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
+            (file-name (git-file-name name version))))
+   (build-system emacs-build-system)
+   (home-page "https://protesilaos.com/emacs/mct")
+   (synopsis "Enhancement of the default Emacs minibuffer completion UI")
+   (description "Minibuffer and Completions in Tandem, also known as mct, or
+mct.el, is a package that enhances the default minibuffer and *Completions*
+buffer of Emacs 27 (or higher) so that they work together as part of a unified
+framework.  The idea is to make the presentation and overall functionality be
+consistent with other popular, vertically aligned completion UIs while
+leveraging built-in functionality.")
+   (license license:gpl3+)))
-- 
2.34.0

[Message part 3 (text/plain, inline)]

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 53812-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 53812-done <at> debbugs.gnu.org, Protesilaos Stavrou <public <at> protesilaos.com>
Subject: Re: [bug#53812] [PATCH] gnu: Add emacs-mct.
Date: Tue, 08 Feb 2022 01:11:32 +0100

Hello,

Andrew Tropin <andrew <at> trop.in> writes:

> Subject: [PATCH v2] gnu: Add emacs-mct.

Thanks.

I removed ".git" suffix from source URL, removed reference to Emacs
version in the description, and pushed.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.