GNU bug report logs - #53769
Implementation of X11 MULTIPLE selection is incomplete (with patches)

Previous Next

Package: emacs;

Reported by: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>

Date: Fri, 4 Feb 2022 03:38:02 UTC

Severity: normal

Done: Po Lu <luangruo <at> yahoo.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>
Cc: 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is
 incomplete (with patches)
Date: Fri, 04 Feb 2022 12:57:58 +0800

Your change LGTM, but:

> +  if (! for_multiple && actual_type == dpyinfo->Xatom_INCR)

We typically don't put a space between the "!" and "for_multiple" here.
The surrounding code does it a lot, but there's no reason to introduce
any more instances of that style.

Thanks.
This bug report was last modified 3 years and 109 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.