GNU bug report logs - #53769
Implementation of X11 MULTIPLE selection is incomplete (with patches)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53769 in the body.
You can then email your comments to 53769 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Implementation of X11 MULTIPLE selection is incomplete (with patches)
Date: Fri, 4 Feb 2022 03:01:43 +0000

[Message part 1 (text/plain, inline)]

1 - Emacs deletes the MULTIPLE property (with the requested
target/property atom pairs) after reading it; whereas it should be
deleted by the requestor, not the owner.
2 - Emacs should update the MULTIPLE property with the conversion
outcome for each target (i.e. None if the conversion failed)

Patches attached, please see commit messages for details. I've
previously signed the paperwork.

[0001-Do-not-delete-the-MULTIPLE-property-after-reading-it.patch (text/x-patch, attachment)]

[0002-Update-the-MULTIPLE-property-with-conversion-outcome.patch (text/x-patch, attachment)]

Message #8 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>
Cc: 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is
 incomplete (with patches)
Date: Fri, 04 Feb 2022 12:57:58 +0800

Your change LGTM, but:

> +  if (! for_multiple && actual_type == dpyinfo->Xatom_INCR)

We typically don't put a space between the "!" and "for_multiple" here.
The surrounding code does it a lot, but there's no reason to introduce
any more instances of that style.

Thanks.

Message #11 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is incomplete
 (with patches)
Date: Fri, 4 Feb 2022 13:09:01 +0000

[Message part 1 (text/plain, inline)]

Okay, here are the patches with that formatting tweak applied.

- Vladimir

On Fri, 4 Feb 2022 at 04:58, Po Lu <luangruo <at> yahoo.com> wrote:
>
>
> Your change LGTM, but:
>
> > +  if (! for_multiple && actual_type == dpyinfo->Xatom_INCR)
>
> We typically don't put a space between the "!" and "for_multiple" here.
> The surrounding code does it a lot, but there's no reason to introduce
> any more instances of that style.
>
> Thanks.

[0001-Do-not-delete-the-MULTIPLE-property-after-reading-it.patch (text/x-patch, attachment)]

[0002-Update-the-MULTIPLE-property-with-conversion-outcome.patch (text/x-patch, attachment)]

Message #14 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is
 incomplete (with patches)
Date: Fri, 04 Feb 2022 22:03:58 +0800

Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com> writes:

> Okay, here are the patches with that formatting tweak applied.

Thanks, if your copyright papers are in order this can be installed.

Eli, is the copyright paperwork complete for this change?  Thanks.

Message #17 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: vladimir.panteleev.md <at> gmail.com, 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is
 incomplete (with patches)
Date: Fri, 04 Feb 2022 16:41:59 +0200

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: 53769 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> Date: Fri, 04 Feb 2022 22:03:58 +0800
> 
> Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com> writes:
> 
> > Okay, here are the patches with that formatting tweak applied.
> 
> Thanks, if your copyright papers are in order this can be installed.
> 
> Eli, is the copyright paperwork complete for this change?  Thanks.

Yes, Vladimir's copyright assignment for Emacs is on file.

Message #20 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: vladimir.panteleev.md <at> gmail.com, 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is
 incomplete (with patches)
Date: Sat, 05 Feb 2022 09:02:10 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Yes, Vladimir's copyright assignment for Emacs is on file.

Great, I'll install this.  Thanks.

Message #25 received at 53769-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: vladimir.panteleev.md <at> gmail.com, 53769-done <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is
 incomplete (with patches)
Date: Sat, 05 Feb 2022 09:07:50 +0800

Po Lu <luangruo <at> yahoo.com> writes:

> Great, I'll install this.  Thanks.

Now done, so I'm closing this bug.

Thanks for working on Emacs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.