GNU bug report logs - #53769
Implementation of X11 MULTIPLE selection is incomplete (with patches)

Previous Next

Full log

Message #11 received at 53769 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Panteleev <vladimir.panteleev.md <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 53769 <at> debbugs.gnu.org
Subject: Re: bug#53769: Implementation of X11 MULTIPLE selection is incomplete
 (with patches)
Date: Fri, 4 Feb 2022 13:09:01 +0000

[Message part 1 (text/plain, inline)]

Okay, here are the patches with that formatting tweak applied.

- Vladimir

On Fri, 4 Feb 2022 at 04:58, Po Lu <luangruo <at> yahoo.com> wrote:
>
>
> Your change LGTM, but:
>
> > +  if (! for_multiple && actual_type == dpyinfo->Xatom_INCR)
>
> We typically don't put a space between the "!" and "for_multiple" here.
> The surrounding code does it a lot, but there's no reason to introduce
> any more instances of that style.
>
> Thanks.

[0001-Do-not-delete-the-MULTIPLE-property-after-reading-it.patch (text/x-patch, attachment)]

[0002-Update-the-MULTIPLE-property-with-conversion-outcome.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.