GNU bug report logs - #53707
[PATCH] Fix bad substitution in Elixir recipe

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53707: closed ([PATCH] Fix bad substitution in Elixir recipe)
Date: Thu, 24 Feb 2022 03:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 23 Feb 2022 22:01:38 -0500
with message-id <8735k9m0h9.fsf <at> gmail.com>
and subject line Re: bug#53707: [PATCH] Fix bad substitution in Elixir recipe
has caused the debbugs.gnu.org bug report #53707,
regarding [PATCH] Fix bad substitution in Elixir recipe
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53707: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53707
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Cees de Groot <cg <at> evrl.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Fix bad substitution in Elixir recipe
Date: Tue, 01 Feb 2022 18:32:09 +0000

From d8148d5bb2d17f96c1a8034b1854f2b9f890e37a Mon Sep 17 00:00:00 2001
From: Cees de Groot <cg <at> evrl.com>
Date: Tue, 1 Feb 2022 13:29:33 -0500
Subject: [PATCH] Fix /bin/sh replacement for Elixir

I have no clue where this went wrong, but substituting "sh" instead of "/bin/sh" was bound to fail. Maybe something upstream changed? In any case, this should be more correct.

---
 gnu/packages/elixir.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
index 3fb74a56a5..fae8279e5c 100644
--- a/gnu/packages/elixir.scm
+++ b/gnu/packages/elixir.scm
@@ -68,7 +68,7 @@ (define-public elixir
               (substitute* '("lib/mix/lib/mix/release.ex"
                              "lib/mix/lib/mix/tasks/release.init.ex")
                 (("#!/bin/sh")
-                 (string-append "#!" (search-input-file inputs "sh"))))
+                 (string-append "#!" (search-input-file inputs "/bin/sh"))))
               (substitute* "bin/elixir"
                 (("^ERTS_BIN=$")
                  (string-append
--
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Cees de Groot <cg <at> evrl.com>
Cc: 53707-done <at> debbugs.gnu.org
Subject: Re: bug#53707: [PATCH] Fix bad substitution in Elixir recipe
Date: Wed, 23 Feb 2022 22:01:38 -0500

Hi,

Cees de Groot <cg <at> evrl.com> writes:

>>From d8148d5bb2d17f96c1a8034b1854f2b9f890e37a Mon Sep 17 00:00:00 2001
> From: Cees de Groot <cg <at> evrl.com>
> Date: Tue, 1 Feb 2022 13:29:33 -0500
> Subject: [PATCH] Fix /bin/sh replacement for Elixir
>
> I have no clue where this went wrong, but substituting "sh" instead of "/bin/sh" was bound to fail. Maybe something upstream changed? In any case, this should be more correct.
>
> ---
>  gnu/packages/elixir.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
> index 3fb74a56a5..fae8279e5c 100644
> --- a/gnu/packages/elixir.scm
> +++ b/gnu/packages/elixir.scm
> @@ -68,7 +68,7 @@ (define-public elixir
>                (substitute* '("lib/mix/lib/mix/release.ex"
>                               "lib/mix/lib/mix/tasks/release.init.ex")
>                  (("#!/bin/sh")
> -                 (string-append "#!" (search-input-file inputs "sh"))))
> +                 (string-append "#!" (search-input-file inputs "/bin/sh"))))
>                (substitute* "bin/elixir"
>                  (("^ERTS_BIN=$")
>                   (string-append
> --
> 2.34.0

This has already been fixed by Ludovic in commit
d5353e24700102eb3fbf872800135b13e0268ea1.

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.