GNU bug report logs - #53706
[PATCH] gnu: Disable compressed debug sections for mingw-w64

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53706 in the body.
You can then email your comments to 53706 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: guix-patches <at> gnu.org
Cc: Carl Dong <contact <at> carldong.me>
Subject: [PATCH] gnu: Disable compressed debug sections for mingw-w64
Date: Tue,  1 Feb 2022 13:22:03 -0500

The newly introduced --enable-compressed-debug-section=all configure
flag in the base binutils package makes the mingw-w64 build system
unusable. For example:

    $ guix build --target=x86_64-w64-mingw32 hello

        and

    $ guix build mingw-w64-x86_64-winpthreads

Will fail to build with an error:

    "x86_64-w64-mingw32-ld: final link failed: bad value"

Turning off this flag seems to fix the problem, but perhaps it'd also be
worthwhile to investigate the root cause.

* gnu/packages/cross-base.scm (cross-binutils): When building for mingw
  targets, append "--enable-compressed-debug-section=no" to configure
  flags.
---
 gnu/packages/cross-base.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm
index 78cbf871ac..529144d127 100644
--- a/gnu/packages/cross-base.scm
+++ b/gnu/packages/cross-base.scm
@@ -101,7 +101,16 @@ (define* (cross-binutils target #:optional (binutils binutils))
                                          "ath9k-htc-firmware-binutils.patch")))
                  ((target-mingw? target)
                   (package-with-extra-patches
-                   binutils
+                   (package-with-extra-configure-variable
+                    ;; mingw binutils does not work correctly when configured
+                    ;; with `--enable-compressed-debug-sections`. An error
+                    ;; like the following will occur whenever you try to link:
+                    ;;
+                    ;;   x86_64-w64-mingw32-ld: final link failed: bad value
+                    ;;
+                    ;; TODO: This seems like a deeper problem that warrants
+                    ;; deeper investigation.
+                    binutils "--enable-compressed-debug-sections" "no")
                    (search-patches "binutils-mingw-w64-timestamp.patch"
                                    "binutils-mingw-w64-deterministic.patch")))
                  (else binutils))
-- 
2.34.1

Message #10 received at 53706 <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: 53706 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 lle-bout <at> zaclys.net
Subject: re: [PATCH] gnu: Disable compressed debug sections for mingw-w64
Date: Thu, 3 Feb 2022 13:51:42 -0500

[Message part 1 (text/plain, inline)]

Just for some extra context, this commit should not trigger mass rebuilds. I’m happy to commit it myself, but would someone to give me a quick sanity check before doing so!

Related: https://issues.guix.gnu.org/53426 <https://issues.guix.gnu.org/53426>

Cheers,
Carl Dong

[Message part 2 (text/html, inline)]

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 53706 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Carl Dong <contact <at> carldong.me>
Cc: 53706 <at> debbugs.gnu.org, lle-bout <at> zaclys.net
Subject: Re: [PATCH] gnu: Disable compressed debug sections for mingw-w64
Date: Sat, 05 Feb 2022 23:59:31 -0500

Hi Carl,

Carl Dong <contact <at> carldong.me> writes:

> Just for some extra context, this commit should not trigger mass
> rebuilds. I’m happy to commit it myself, but would someone to give me
> a quick sanity check before doing so!
>
> Related: https://issues.guix.gnu.org/53426 <https://issues.guix.gnu.org/53426>

I just had a quick look, and it LGTM.

Thanks,

Maxim

Message #18 received at 53706-done <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: 53706-done <at> debbugs.gnu.org
Subject: Closing
Date: Mon, 7 Feb 2022 16:40:25 -0500

In master as of 2d78b27711d44f39fabf170d044b45247af7babe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.