GNU bug report logs - #53704
Add Visualboyadvance-m

Previous Next

Full log

Message #32 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 23:45:34 +0000

Thanks for the review, Maxime! That is a lot of stuff I did not know about. Your new version of the patch works for me except for the (list (local-file part which I think should be (search-patches.

What should I do about the library code duplication and licensing issues? Should I bring it upu with the project maintainers?

------- Original Message -------

On Saturday, February 12th, 2022 at 7:31 AM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> Hi,
>
> I've modified the package definition and patch a bit to
>
> make it simpler (visualboyadvance-m-fix-rpath.patch now only removed
>
> things), cross-compilable (it uses cc-for-target instead of hardcoding
>
> "gcc" and LIBRARY_PATH is unused) and avoid using constructs that
>
> are being deprecated (%build-inputs --> this-package-input).
>
> The list+local-file will have to be replaced by search-patches.
>
> Cross-compilation is untested because gtk+ cannot currently be
>
> cross-compiled.
>
> It seems to work, at least the application starts, I don't have any VBA
>
> games to test it with.
>
> Greetings,
>
> Maxime.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.