GNU bug report logs - #53704
Add Visualboyadvance-m

Previous Next

To reply to this bug, email your comments to 53704 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Add Visualboyadvance-m
Date: Tue, 01 Feb 2022 17:36:34 +0000

[Message part 1 (text/plain, inline)]

Please review the way that I did the patch files because I am not sure if they are linline with guix standards.

[Message part 2 (text/html, inline)]

[0001-gnu-emulators-Add-visualboyadvance-m.patch (text/x-patch, attachment)]

Message #8 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Bump
Date: Fri, 11 Feb 2022 06:51:31 +0000

Is there any chance this can get merged? If there is something wrong with the package, I am happy to fix it.

Message #11 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Charles <charles.b.jackson <at> protonmail.com>,
 "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Fri, 11 Feb 2022 08:05:08 +0100

[Message part 1 (text/plain, inline)]

Your patch looks good, though I haven't tested yet. In your synopsis, it's "an emulator", not "a emulator". The patches should contain author information. Did you create them yourself? Did you get them from somewhere else?

The gcc patch could be replaced with a phase that substitutes cc for gcc.

You need to add the patches to gnu/local.mk.

Thanks!

On February 11, 2022 7:51:31 AM GMT+01:00, Charles via Guix-patches via <guix-patches <at> gnu.org> wrote:
>Is there any chance this can get merged? If there is something wrong with the package, I am happy to fix it.
>
>
>
>

[Message part 2 (text/html, inline)]

Message #14 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 00:30:06 +0000

[Message part 1 (text/plain, inline)]

Thanks for the review, Julien. Here is a new patch that includes your suggestions.

------- Original Message -------

On Friday, February 11th, 2022 at 1:05 AM, Julien Lepiller <julien <at> lepiller.eu> wrote:

> Your patch looks good, though I haven't tested yet. In your synopsis, it's "an emulator", not "a emulator". The patches should contain author information. Did you create them yourself? Did you get them from somewhere else?
>
> The gcc patch could be replaced with a phase that substitutes cc for gcc.
>
> You need to add the patches to gnu/local.mk.
>
> Thanks!
>
> On February 11, 2022 7:51:31 AM GMT+01:00, Charles via Guix-patches via <guix-patches <at> gnu.org> wrote:
>
> > Is there any chance this can get merged? If there is something wrong with the package, I am happy to fix it.

[0001-gnu-emulators-Add-visualboyadvance-m.patch (text/x-patch, attachment)]

Message #17 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Charles <charles.b.jackson <at> protonmail.com>, Julien Lepiller
 <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 10:54:08 +0100

[Message part 1 (text/plain, inline)]

Charles via Guix-patches via schreef op za 12-02-2022 om 00:30 [+0000]:
> +               ((" cc ") " gcc "))))

This needs to be TARGET-gcc when cross-compiling, use cc-for-target:

((" cc ") (string-append " " ,(cc-for-target) " "))

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Charles <charles.b.jackson <at> protonmail.com>, Julien Lepiller
 <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 11:11:06 +0100

[Message part 1 (text/plain, inline)]

Charles via Guix-patches via schreef op za 12-02-2022 om 00:30 [+0000]:
> ++        set(MY_C_LINKER_FLAGS ${MY_C_LINKER_FLAGS} "-Wl,-
> rpath,$ENV{LIBRARY_PATH}")

When cross-compiling, CROSS_LIBRARY_PATH needs to be used instead.
Usually, fiddling with rpaths manually is unnecessary, Guix does
that automatically in most situations.  I'll look into this.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Charles <charles.b.jackson <at> protonmail.com>, Julien Lepiller
 <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 12:35:29 +0100

[Message part 1 (text/plain, inline)]

Charles via Guix-patches via schreef op za 12-02-2022 om 00:30 [+0000]:
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url
> "https://github.com/visualboyadvance-m/visualboyadvance-m/")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "1kgpbvng3c12ws0dy92zc0azd94h0i3j4vm7b67zc8mi3pqsppdg"))
> +       (patches (search-patches "visualboyadvance-m-fix-
> rpath.patch"))))

The iniparser package is bundled in src/common/iniparser.c and
src/common/iniparser.h.

A part of a variant of zlib is in src/common/memgzio.c and
src/common/memgzio.h.  I think it's ok in this case, since it appears
to be modified for use in visualboyadvance-m.  However, the license of
zlib needs to be respected:

/* gzio.c -- IO on .gz files
 * Copyright (C) 1995-2002 Jean-loup Gailly.
 * For conditions of distribution and use, see copyright notice in
zlib.h
 *
 * Compile this file with -DNO_DEFLATE to avoid the compression code.
 */

I don't see zlib.h anywhere and the zlib license requires preserving
the license notice:

  3. This notice may not be removed or altered from any source
distribution.

There is another problem: the version in visualboyadvance-m is old
(2002, according to the copyright line) while there have been
quite a few bugfixes since then (https://www.zlib.net/ChangeLog.txt).

Another bundled library: src/common/dictionary.c and
src/common/dictionary.h.

There is also src/filters/bilinear.cpp which is extracted from Exult
(GPL2+ licensed), but it appears that the copyright+license header was
not preserved, while preserving that is a requirement of the GPL IIUC?

The files in src/filters/xBRZ are GPL3 licensed, so 'license:gpl2+'
in the package definition seems inaccurate.  It is unclear of GPL3-only
or GPL3-or-later was meant.

The file src/gba/debugger-expr-lex.cpp and src/gba/debugger-expr-
yacc.cpp are generated by flex and Bison, can they be generated during
the build?

libretro is bundled in src/libretro, can it be unbundled?

src/expr.cpp and src/expr.cpp.h are generated files, not source code.

A part of glibc is bundled in src/sdl/getopt1.c, src/sdl/getopt.c
and src/sdl/getopt.h.

wxwidgets is bundled in src/wx.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Charles <charles.b.jackson <at> protonmail.com>, Julien Lepiller
 <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 13:17:16 +0100

[Message part 1 (text/plain, inline)]

Maxime Devos schreef op za 12-02-2022 om 12:35 [+0100]:
> wxwidgets is bundled in src/wx.

Nevermind, it's only wxwidgets-related, not wxwidgets itself.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Charles <charles.b.jackson <at> protonmail.com>, Julien Lepiller
 <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 14:31:22 +0100

[Message part 1 (text/plain, inline)]

Hi,

I've modified the package definition and patch a bit to
make it simpler (visualboyadvance-m-fix-rpath.patch now only removed
things), cross-compilable (it uses cc-for-target instead of hardcoding
"gcc" and LIBRARY_PATH is unused) and avoid using constructs that
are being deprecated (%build-inputs --> this-package-input).

The list+local-file will have to be replaced by search-patches.

Cross-compilation is untested because gtk+ cannot currently be
cross-compiled.

It seems to work, at least the application starts, I don't have any VBA
games to test it with.

Greetings,
Maxime.

[visualboyadvance-m.scm (text/x-scheme, attachment)]

[visualboyadvance-m-fix-rpath.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: [bug#53704] Bump
Date: Sat, 12 Feb 2022 23:45:34 +0000

Thanks for the review, Maxime! That is a lot of stuff I did not know about. Your new version of the patch works for me except for the (list (local-file part which I think should be (search-patches.

What should I do about the library code duplication and licensing issues? Should I bring it upu with the project maintainers?

------- Original Message -------

On Saturday, February 12th, 2022 at 7:31 AM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> Hi,
>
> I've modified the package definition and patch a bit to
>
> make it simpler (visualboyadvance-m-fix-rpath.patch now only removed
>
> things), cross-compilable (it uses cc-for-target instead of hardcoding
>
> "gcc" and LIBRARY_PATH is unused) and avoid using constructs that
>
> are being deprecated (%build-inputs --> this-package-input).
>
> The list+local-file will have to be replaced by search-patches.
>
> Cross-compilation is untested because gtk+ cannot currently be
>
> cross-compiled.
>
> It seems to work, at least the application starts, I don't have any VBA
>
> games to test it with.
>
> Greetings,
>
> Maxime.

Message #35 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: [bug#53704] Bump
Date: Sun, 27 Feb 2022 00:19:22 +0000

What are the next steps for this project? Do the licensing issues make it not allowed to be in guix?

------- Original Message -------

On Saturday, February 12th, 2022 at 5:45 PM, Charles <charles.b.jackson <at> protonmail.com> wrote:

> Thanks for the review, Maxime! That is a lot of stuff I did not know about. Your new version of the patch works for me except for the (list (local-file part which I think should be (search-patches.
>
> What should I do about the library code duplication and licensing issues? Should I bring it upu with the project maintainers?
>
> ------- Original Message -------
>
> On Saturday, February 12th, 2022 at 7:31 AM, Maxime Devos maximedevos <at> telenet.be wrote:
>
> > Hi,
> >
> > I've modified the package definition and patch a bit to
> >
> > make it simpler (visualboyadvance-m-fix-rpath.patch now only removed
> >
> > things), cross-compilable (it uses cc-for-target instead of hardcoding
> >
> > "gcc" and LIBRARY_PATH is unused) and avoid using constructs that
> >
> > are being deprecated (%build-inputs --> this-package-input).
> >
> > The list+local-file will have to be replaced by search-patches.
> >
> > Cross-compilation is untested because gtk+ cannot currently be
> >
> > cross-compiled.
> >
> > It seems to work, at least the application starts, I don't have any VBA
> >
> > games to test it with.
> >
> > Greetings,
> >
> > Maxime.

Message #38 received at 53704 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Charles <charles.b.jackson <at> protonmail.com>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: [bug#53704] Bump
Date: Sun, 27 Feb 2022 11:52:32 +0100

[Message part 1 (text/plain, inline)]

Charles schreef op za 12-02-2022 om 23:45 [+0000]:
> What should I do about the library code duplication and licensing issues?
> Should I bring it upu with the project maintainers?

The licensing should be brought up with the project maintainers.
The unbundling can be brought up with the maintainers, while probably
they will keep bundling, perhaps they could support some
"-DUSE_SYSTEM_ZLIB" kind of configure flags.

If upstream is unresponsive or keeps bundling, it may be possible to
unbundle it in Guix itself even though upstream bundles.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.