GNU bug report logs - #53704
Add Visualboyadvance-m

Previous Next

Full log

View this message in rfc822 format

From: Charles <charles.b.jackson <at> protonmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: "53704 <at> debbugs.gnu.org" <53704 <at> debbugs.gnu.org>
Subject: [bug#53704] Bump
Date: Sat, 12 Feb 2022 00:30:06 +0000

[Message part 1 (text/plain, inline)]

Thanks for the review, Julien. Here is a new patch that includes your suggestions.

------- Original Message -------

On Friday, February 11th, 2022 at 1:05 AM, Julien Lepiller <julien <at> lepiller.eu> wrote:

> Your patch looks good, though I haven't tested yet. In your synopsis, it's "an emulator", not "a emulator". The patches should contain author information. Did you create them yourself? Did you get them from somewhere else?
>
> The gcc patch could be replaced with a phase that substitutes cc for gcc.
>
> You need to add the patches to gnu/local.mk.
>
> Thanks!
>
> On February 11, 2022 7:51:31 AM GMT+01:00, Charles via Guix-patches via <guix-patches <at> gnu.org> wrote:
>
> > Is there any chance this can get merged? If there is something wrong with the package, I am happy to fix it.

[0001-gnu-emulators-Add-visualboyadvance-m.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.