GNU bug report logs - #5370
M-x hexl-mode M-x hexl-mode leaves unwanted ruler

Previous Next

Package: emacs;

Reported by: Juanma Barranquero <lekktu <at> gmail.com>

Date: Wed, 13 Jan 2010 04:53:01 UTC

Severity: normal

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 5370 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: cyd <at> stupidchicken.com
Cc: 5370 <at> debbugs.gnu.org
Subject: Re: bug#5370: M-x hexl-mode M-x hexl-mode leaves unwanted ruler
Date: Thu, 1 Jul 2010 02:21:03 +0200

On Thu, Jul 1, 2010 at 00:46, Chong Yidong <cyd <at> stupidchicken.com> wrote:

> The solution is to avoid saving the old header-line-format if Ruler mode
> is already on.  I've checked in a fix.

OK, thanks.

A couple questions:

Why do you need "(when enable" in ruler--save-header-line-format,
which causes this warning

  ruler-mode.el:562:9:Warning: reference to free variable `enable'

when ruler--save-header-line-format is only called once, like so

  (when enable
     (ruler--save-header-line-format))

?

Also, the docstring for r--s-h-l-f says

"Install the header line format for Ruler mode.
Unless if Ruler mode is already enabled, save the old header line
format first."

Shouldn't that be s/Unless if/Unless/?

    Juanma
This bug report was last modified 15 years and 42 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.