GNU bug report logs - #5369
Emacs Compiler bug: freeze advice, dynamic-docstrings: nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5369 in the body.
You can then email your comments to 5369 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Glenn Morris <rgm <at> gnu.org>
Subject: Emacs Compiler bug: freeze advice, dynamic-docstrings: nil
Date: Tue, 12 Jan 2010 23:29:41 +0100

Hello Glenn,

some days ago, you closed my bug report concerning the Byte Compiler of
Gnu Emacs. I have found another compiler bug, and since you seem to be
involved in the last changes of bytecomp.el, I send it to you instead of
opening a new bug report; I hope this is ok; could you please check if
the following can be reproduced with the current version of bytecomp?

Byte compile the following file with emacs -Q:

;; -*- byte-compile-dynamic-docstrings: nil -*-

(defadvice startup-echo-area-message
  (around my-startup-echo-area-message freeze)
  "This is a test advice."
  (setq ad-return-value
	"Welcome to GNU Emacs and happy hacking!"))

Compilation succeeds, but when I load the resulting file, I get an
error:

Load error for /media/sda1/test.elc:
(invalid-read-syntax #)

My compiled file looks like this:

;ELC..
;;; Compiled by micha <at> dragon on Sat Jan  9 22:32:31 2010
;;; from file /media/sdb1/test.el
;;; in Emacs version 23.1.1
;;; with all optimizations.

;;; This file uses opcodes which do not exist in Emacs 18.
(if (and (boundp 'emacs-version)
	 (< (aref emacs-version (1- (length emacs-version))) ?A)
	 (or (and (boundp 'epoch::version) epoch::version)
	     (string-lessp emacs-version "19")))
    (error "`test.el' was compiled for Emacs 19 or later"))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;


(byte-code "\301\302!\204.\302\300\303\304N\236A.\301!\205.K)\206.\303KM\210\301\207" [origname fboundp ad-Orig-startup-echo-area-message-around-my-startup-echo-area-message startup-echo-area-message ad-advice-info] 4)
(defalias 'startup-echo-area-message #[nil "\301.\302.)\302\207" [ad-return-value nil "Welcome to GNU Emacs and happy hacking!"] 1 #\
("This function is advised.

Permanent around-advice `my-startup-echo-area-message':
This is a test advice." 0 25 (face font-lock-warning-face ad-advice-info startup-echo-area-message) 25 105 (ad-advice-info startup-echo-area-message))])

This was done with Emacs 23.1.1; the problem doesn't appear in my Emacs 22.


Thanks in advance,

Michael.

Message #8 received at 5369 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5369 <at> debbugs.gnu.org
Subject: Re: Bug#5369: Emacs Compiler bug: freeze advice,
	dynamic-docstrings: nil
Date: Thu, 21 Jan 2010 00:08:02 -0500

Michael Heerdegen wrote:

> (defalias 'startup-echo-area-message #[nil "\301.\302.)\302\207" [ad-return-value nil "Welcome to GNU Emacs and happy hacking!"] 1 #\
> ("This function is advised.
>
> Permanent around-advice `my-startup-echo-area-message':
> This is a test advice." 0 25 (face font-lock-warning-face ad-advice-info startup-echo-area-message) 25 105 (ad-advice-info startup-echo-area-message))])

This seems to be because ad-make-advised-docstring returns a propertized
doc-string. I don't know how to make it not do that when the output is
to be used for compilation.

Message #15 received at 5369-done <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 5369-done <at> debbugs.gnu.org
Subject: Emacs Compiler bug: freeze advice, dynamic-docstrings: nil
Date: Thu, 2 Jun 2016 16:45:05 -0400

found 5369 24.3
quit

In 24.4 defadvice no longer supports the `freeze' flag, so this bug is
no longer applicable.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.