GNU bug report logs - #5367
23.1; gnus -- Inconsistent mml-secure-message-sign method

Previous Next

Packages: emacs, gnus;

Reported by: Tommi Vainikainen <thv <at> iki.fi>

Date: Tue, 12 Jan 2010 20:38:02 UTC

Severity: normal

Tags: patch

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5367 in the body.
You can then email your comments to 5367 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#5367; Package emacs. (Tue, 12 Jan 2010 20:38:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Tommi Vainikainen <thv <at> iki.fi>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 12 Jan 2010 20:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tommi Vainikainen <thv <at> iki.fi>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; gnus -- Inconsistent mml-secure-message-sign method
Date: Tue, 12 Jan 2010 21:53:18 +0200

[Message part 1 (text/plain, inline)]
Hi,

currently gnus/lisp/mml-sec.el contains definitions for functions
mml-secure-sign and mml-secure-message-sign which have equal bodies and
description. However when comparing mml-secure-message-sign with
mml-secure-message-* functions, one would expect that also
mml-secure-message-sign would set signing to the entire message, not
only current MML part. I believe that the current version is copy&paste
error, which caused this inconsistency in the function declarations.
Following patch fixes the problem:


[gnus-mml-secure-message-sign.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
-- 
Tommi Vainikainen
bug reassigned from package 'emacs' to 'emacs,gnus'. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 13 Jan 2010 17:40:03 GMT) Full text and rfc822 format available.
Added tag(s) patch. Request was from Juanma Barranquero <lekktu <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 18 Jan 2010 15:31:01 GMT) Full text and rfc822 format available.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org, bugs <at> gnus.org:
bug#5367; Package emacs,gnus. (Thu, 06 May 2010 05:59:01 GMT) Full text and rfc822 format available.

Message #12 received at 5367 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Seltenreich <seltenreich <at> gmx.de>
To: Tommi Vainikainen <thv <at> iki.fi>
Cc: 5367 <at> debbugs.gnu.org
Subject: Re: bug#5367: 23.1;
	gnus -- Inconsistent mml-secure-message-sign method
Date: Thu, 06 May 2010 07:50:24 +0200

Tommi Vainikainen writes:

> currently gnus/lisp/mml-sec.el contains definitions for functions
> mml-secure-sign and mml-secure-message-sign which have equal bodies and
> description. However when comparing mml-secure-message-sign with
> mml-secure-message-* functions, one would expect that also
> mml-secure-message-sign would set signing to the entire message, not
> only current MML part. I believe that the current version is copy&paste
> error, which caused this inconsistency in the function declarations.
> Following patch fixes the problem:

Thanks - I committed your patch to the Gnus repository.  I'll leave this
bug open till the change is merged into emacs though.

Thanks,
andreas
bug closed, send any further explanations to Tommi Vainikainen <thv <at> iki.fi> Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Fri, 07 May 2010 17:23:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 05 Jun 2010 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 78 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.