GNU bug report logs - #53660
[PATCH] services/sound: Add a udev extension for the pulseaudio service type.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: bug#53660: closed (Re: [PATCH] services/sound: Add a udev
 extension for the pulseaudio service type.)
Date: Wed, 02 Feb 2022 02:55:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53660: [PATCH] services/sound: Add a udev extension for the pulseaudio service type.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53660 <at> debbugs.gnu.org.

-- 
53660: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53660
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 53660-done <at> debbugs.gnu.org
Subject: Re: [PATCH] services/sound: Add a udev extension for the pulseaudio
 service type.
Date: Tue, 01 Feb 2022 21:54:11 -0500

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
>> PulseAudio provides udev rules used to adjust the configuration of
>> certain
>> hardware (e.g., sound cards); ensure they get used.
>> 
>> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
>> udev-service-type with the pulseaudio package.
>> ---
>>  gnu/services/sound.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
>> index 1217223a0c..7beca35ffe 100644
>> --- a/gnu/services/sound.scm
>> +++ b/gnu/services/sound.scm
>> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
>>     (extensions
>>      (list (service-extension session-environment-service-type
>>                               pulseaudio-environment)
>> -          (service-extension etc-service-type pulseaudio-etc)))
>> +          (service-extension etc-service-type pulseaudio-etc)
>> +          (service-extension udev-service-type (lambda _
>> +                                                 (list
>> pulseaudio)))))
> You should use const, otherwise SGTM.

Good catch!  Adjusted and pushed as
fff4daa5c2bfbf42c7ad2519f500bd254ce880a8.

Thank you,

Maxim

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] services/sound: Add a udev extension for the pulseaudio
 service type.
Date: Mon, 31 Jan 2022 09:54:07 -0500

PulseAudio provides udev rules used to adjust the configuration of certain
hardware (e.g., sound cards); ensure they get used.

* gnu/services/sound.scm (pulseaudio-service-type): Extend the
udev-service-type with the pulseaudio package.
---
 gnu/services/sound.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 1217223a0c..7beca35ffe 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -159,7 +159,9 @@ (define pulseaudio-service-type
    (extensions
     (list (service-extension session-environment-service-type
                              pulseaudio-environment)
-          (service-extension etc-service-type pulseaudio-etc)))
+          (service-extension etc-service-type pulseaudio-etc)
+          (service-extension udev-service-type (lambda _
+                                                 (list pulseaudio)))))
    (default-value (pulseaudio-configuration))
    (description "Configure PulseAudio sound support.")))
 
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.