GNU bug report logs - #53660
[PATCH] services/sound: Add a udev extension for the pulseaudio service type.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53660 in the body.
You can then email your comments to 53660 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] services/sound: Add a udev extension for the pulseaudio
 service type.
Date: Mon, 31 Jan 2022 09:54:07 -0500

PulseAudio provides udev rules used to adjust the configuration of certain
hardware (e.g., sound cards); ensure they get used.

* gnu/services/sound.scm (pulseaudio-service-type): Extend the
udev-service-type with the pulseaudio package.
---
 gnu/services/sound.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 1217223a0c..7beca35ffe 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -159,7 +159,9 @@ (define pulseaudio-service-type
    (extensions
     (list (service-extension session-environment-service-type
                              pulseaudio-environment)
-          (service-extension etc-service-type pulseaudio-etc)))
+          (service-extension etc-service-type pulseaudio-etc)
+          (service-extension udev-service-type (lambda _
+                                                 (list pulseaudio)))))
    (default-value (pulseaudio-configuration))
    (description "Configure PulseAudio sound support.")))
 
-- 
2.34.0

Message #8 received at 53660 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 53660 <at> debbugs.gnu.org
Subject: Re: [PATCH] services/sound: Add a udev extension for the pulseaudio
 service type.
Date: Tue, 01 Feb 2022 20:25:58 +0100

Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
> PulseAudio provides udev rules used to adjust the configuration of
> certain
> hardware (e.g., sound cards); ensure they get used.
> 
> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
> udev-service-type with the pulseaudio package.
> ---
>  gnu/services/sound.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
> index 1217223a0c..7beca35ffe 100644
> --- a/gnu/services/sound.scm
> +++ b/gnu/services/sound.scm
> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
>     (extensions
>      (list (service-extension session-environment-service-type
>                               pulseaudio-environment)
> -          (service-extension etc-service-type pulseaudio-etc)))
> +          (service-extension etc-service-type pulseaudio-etc)
> +          (service-extension udev-service-type (lambda _
> +                                                 (list
> pulseaudio)))))
You should use const, otherwise SGTM.

Message #13 received at 53660-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 53660-done <at> debbugs.gnu.org
Subject: Re: [PATCH] services/sound: Add a udev extension for the pulseaudio
 service type.
Date: Tue, 01 Feb 2022 21:54:11 -0500

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
>> PulseAudio provides udev rules used to adjust the configuration of
>> certain
>> hardware (e.g., sound cards); ensure they get used.
>> 
>> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
>> udev-service-type with the pulseaudio package.
>> ---
>>  gnu/services/sound.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
>> index 1217223a0c..7beca35ffe 100644
>> --- a/gnu/services/sound.scm
>> +++ b/gnu/services/sound.scm
>> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
>>     (extensions
>>      (list (service-extension session-environment-service-type
>>                               pulseaudio-environment)
>> -          (service-extension etc-service-type pulseaudio-etc)))
>> +          (service-extension etc-service-type pulseaudio-etc)
>> +          (service-extension udev-service-type (lambda _
>> +                                                 (list
>> pulseaudio)))))
> You should use const, otherwise SGTM.

Good catch!  Adjusted and pushed as
fff4daa5c2bfbf42c7ad2519f500bd254ce880a8.

Thank you,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.