GNU bug report logs - #53618
29.0.50; macroexp-warn-and-return incompatible change

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#53526: closed (Re: bug#53618: 29.0.50; macroexp-warn-and-return
 incompatible change)
Date: Sat, 19 Feb 2022 19:21:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53618: 29.0.50; macroexp-warn-and-return API change

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53526 <at> debbugs.gnu.org.

-- 
53618: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53618
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 53618-done <at> debbugs.gnu.org
Subject: Re: bug#53618: 29.0.50; macroexp-warn-and-return incompatible change
Date: Sat, 19 Feb 2022 14:20:25 -0500

> We can't break compatibility in this way, so please go ahead and push
> your patch.

Thanks, done,


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; macroexp-warn-and-return API change
Date: Tue, 25 Jan 2022 11:56:22 -0500

Package: Emacs
Version: 29.0.50


The following change in `macroexp.el` on `master` is not backward
compatible with the Emacs-28 API:

-(defun macroexp-warn-and-return (msg form &optional category compile-only)
+(defun macroexp-warn-and-return (arg msg form &optional category compile-only)

I suspect that the `arg` should be added at the end instead.  While I'm
here I also noticed that `byte-compile-form-stack` is a poor name for
a variable declared in `macroexp.el`.  It should either be renamed to
use the `macroexp-` prefix, or moved to `bytecomp.el` (and it probably
should have a double-hyphen, since I think it's not meant to be used by
anyone but us).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.