GNU bug report logs - #53617
28.0.90; duplicate checks in erc--switch-to-buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53617 in the body.
You can then email your comments to 53617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: emacs-erc <at> gnu.org
Subject: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 19:10:00 -0500

[Message part 1 (text/plain, inline)]

erc--switch-to-buffer has the following code at the end:

             ...
             (when buf
      (erc--buffer-p buf (lambda () t) proc)
      (with-current-buffer buf
(and (derived-mode-p 'erc-mode)
     (or (null proc)
 (eq proc erc-server-process)))))
             ...

but erc--buffer-p is already doing the checks with buf as current
buffer:

(defun erc--buffer-p (buf predicate proc)
  (with-current-buffer buf
    (and (derived-mode-p 'erc-mode)
(or (not proc)
    (eq proc erc-server-process))
(funcall predicate)
buf)))

The entire sexp starting with `with-current-buffer ...` can be removed
without changing the semantics of erc--switch-to-buffer.


In GNU Emacs 28.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30,
cairo version 1.17.4)
 of 2021-12-14 built on medusa
Repository revision: f88c1d222f17d3483bf6f387dc41be4366a047ab
Repository branch: makepkg
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Arch Linux

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
 --with-sound=alsa --with-modules --without-libotf --without-m17n-flt
 --without-gconf --without-gsettings --with-native-compilation
 --with-x-toolkit=gtk3 --without-xaw3d --with-sound=no --without-gpm
 --without-compress-install
 '--program-transform-name=s/\([ec]tags\)/\1.emacs/'
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection'
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LCMS2
LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/l

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  global-flycheck-mode: t
  flycheck-mode: t
  shell-dirtrack-mode: t
  global-ligature-mode: t
  ligature-mode: t
  paredit-mode: t
  rainbow-delimiters-mode: t
  global-company-mode: t
  company-mode: t
  counsel-projectile-mode: t
  counsel-mode: t
  projectile-mode: t
  save-place-mode: t
  electric-pair-mode: t
  recentf-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/guy/.emacs.d/elpa/transient-20211129.1146/transient hides
/usr/share/emacs/28.0.90/lisp/transient

Features:
(shadow sort mail-extr emacsbug sendmail ivy-erc debug backtrace
cl-print two-column misearch multi-isearch apropos erc-list erc-menu
erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match
erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend
erc-loaddefs eieio-opt speedbar ezimage dframe shortdoc tabify gnutls
network-stream nsm rcirc magit-patch mule-util vc-mtn vc-hg vc-bzr
vc-src vc-sccs vc-svn vc-cvs vc-rcs vc bug-reference magit-extras
magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash
magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-files magit-refs
magit-status magit magit-repos magit-apply magit-wip magit-log
which-func magit-diff smerge-mode diff git-commit log-edit message rmc
rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode
mm-bodies mm-encode mailabbrev gmm-utils mailheader pcvs-util add-log
magit-core magit-autorevert autorevert filenotify magit-margin
magit-transient magit-process with-editor server magit-mode transient
magit-git magit-section magit-utils crm mhtml-mode css-mode smie eww
url-queue shr kinsoku svg xml puny mm-url gnus nnheader gnus-util rmail
rmail-loaddefs mail-utils js cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs sgml-mode facemenu dom ffap
purescript-indentation purescript-mode purescript-font-lock
purescript-string purescript-sort-imports purescript-align-imports
haskell-doc inf-haskell haskell-decl-scan imenu haskell
haskell-completions haskell-load haskell-commands highlight-uses-mode
haskell-modules haskell-sandbox haskell-navigate-imports haskell-repl
haskell-svg haskell-collapse hideshow haskell-debug
haskell-interactive-mode haskell-presentation-mode haskell-compile
haskell-hoogle haskell-process haskell-session vc-git diff-mode
vc-dispatcher haskell-mode haskell-cabal haskell-utils haskell-font-lock
haskell-indentation haskell-string haskell-sort-imports haskell-lexeme
haskell-align-imports haskell-complete-module haskell-ghc-support
noutline outline flymake-proc flymake dabbrev haskell-customize flycheck
dash vterm bookmark pp tramp tramp-loaddefs trampver tramp-integration
files-x tramp-compat parse-time iso8601 time-date ls-lisp format-spec
face-remap term shell pcomplete ehelp find-func vterm-module term/xterm
xterm auto-complete popup ligature disp-table paredit rainbow-delimiters
page-break-lines display-line-numbers linum whitespace time
company-oddmuse company-keywords company-etags etags fileloop generator
company-gtags company-dabbrev-code company-dabbrev company-files
company-clang company-capf company-cmake company-semantic
company-template company-bbdb company pcase init exercism interactive
counsel-projectile-ext counsel-projectile counsel xdg advice xref
project dired dired-loaddefs swiper ivy delsel ivy-faces ivy-overlay
colir color comp comp-cstr warnings projectile lisp-mnt mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr grep compile
text-property-search comint ansi-color ibuf-ext ibuffer ibuffer-loaddefs
thingatpt saveplace elec-pair dashboard dashboard-widgets recentf
tree-widget wid-edit all-the-icons all-the-icons-faces data-material
data-weathericons data-octicons data-fileicons data-faicons
data-alltheicons modus-vivendi-theme modus-operandi-theme modus-themes
cl-extra use-package use-package-ensure use-package-delight
use-package-diminish use-package-bind-key bind-key easy-mmode
use-package-core finder-inf geiser-impl help-fns radix-tree help-mode
geiser-custom geiser-base ring proof-site proof-autoloads edmacro kmacro
rx info package browse-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc
paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite emoji-zwj charscript charprop case-table
epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice
button loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit x
multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 1092982 183001)
 (symbols 48 44207 0)
 (strings 32 236718 12429)
 (string-bytes 1 7415412)
 (vectors 16 95829)
 (vector-slots 8 2143178 190013)
 (floats 8 798 606)
 (intervals 56 55744 5618)
 (buffers 992 35))

[Message part 2 (text/html, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org, emacs-erc <at> gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 19:07:43 -0800

Hi Guy,

Thanks for following through with the report.

Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:

> The entire sexp starting with `with-current-buffer ...` can be removed
> without changing the semantics of erc--switch-to-buffer.

You're right, of course. In fact, the same commit that introduced
`erc--buffer-p' added the redundancy as well [1]. It looks like they saw
an opportunity to factor out that predicate and simply forgot to erase
the last of what they'd just obsoleted.

Are you sure you're not into cloning the repo and saving out a patch? No
worries if not. This is great regardless.

Thanks again,
J.P.


[1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: bug-gnu-emacs <at> gnu.org, emacs-erc <at> gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 22:13:41 -0500

[Message part 1 (text/plain, inline)]

Sure. I will do it.  The emacs bug report buffer provided access to a help
page.  It suggested I make a patch with `diff -u`.  Is it preferable to
provide a patch as made with git?

On Fri, Jan 28, 2022, 10:07 PM J.P. <jp <at> neverwas.me> wrote:

> Hi Guy,
>
> Thanks for following through with the report.
>
> Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:
>
> > The entire sexp starting with `with-current-buffer ...` can be removed
> > without changing the semantics of erc--switch-to-buffer.
>
> You're right, of course. In fact, the same commit that introduced
> `erc--buffer-p' added the redundancy as well [1]. It looks like they saw
> an opportunity to factor out that predicate and simply forgot to erase
> the last of what they'd just obsoleted.
>
> Are you sure you're not into cloning the repo and saving out a patch? No
> worries if not. This is great regardless.
>
> Thanks again,
> J.P.
>
>
> [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93
>

[Message part 2 (text/html, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org, emacs-erc <at> gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 19:30:14 -0800

Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:

> Sure. I will do it.

Nice!

> The emacs bug report buffer provided access to a help page. It
> suggested I make a patch with `diff -u`. Is it preferable to provide a
> patch as made with git?

Definitely with git. The "Getting involved with development" section in
CONTRIBUTE lays it out in full [1], but basically (after committing),
you just run something like

  git-format-patch -M origin/master -o /tmp

and look for a file named /tmp/0001-foo.patch and attach that in a
reply.

[1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n54

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: bug-gnu-emacs <at> gnu.org, emacs-erc <at> gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 23:29:31 -0500

[Message part 1 (text/plain, inline)]

Here it is.  I don't think my pgp key is on any keyserver, but I signed it
anyway.  Thank you for the encouragement.

On Fri, Jan 28, 2022 at 10:30 PM J.P. <jp <at> neverwas.me> wrote:

> Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:
>
> > Sure. I will do it.
>
> Nice!
>
> > The emacs bug report buffer provided access to a help page. It
> > suggested I make a patch with `diff -u`. Is it preferable to provide a
> > patch as made with git?
>
> Definitely with git. The "Getting involved with development" section in
> CONTRIBUTE lays it out in full [1], but basically (after committing),
> you just run something like
>
>   git-format-patch -M origin/master -o /tmp
>
> and look for a file named /tmp/0001-foo.patch and attach that in a
> reply.
>
> [1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n54
>

[Message part 2 (text/html, inline)]

[0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch.gpg (application/pgp-encrypted, attachment)]

Message #22 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
Cc: larsi <at> gnus.org, emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sat, 29 Jan 2022 15:49:24 -0800

[Message part 1 (text/plain, inline)]

Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:

> Here it is. I don't think my pgp key is on any keyserver, but I signed
> it anyway.

I'm not sure if Emacs has a policy regarding the signing of everyday
contributions, but if your key isn't signed by anyone and not propagated
among the keyservers, then I'd guess you can probably just skip further
signing in the near term.

> Thank you for the encouragement.

My pleasure. This looks ready for Emacs 29. Thanks.

                              . . .

I've added the customary tweaks to the log message if someone wants to
glance at it (cc. bandali, Lars). Also, question: is there formal
recordkeeping going on re exempt lines accumulated per individual? And
if not, is the recommended way to get a tally just `git log --author=`?

[0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch (text/x-patch, attachment)]

Message #25 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: larsi <at> gnus.org, emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sat, 29 Jan 2022 21:25:28 -0500

[Message part 1 (text/plain, inline)]

Yeah, I should get my keys on some servers.  I finally started signing all
my commits, so I just felt weird about not signing the patch.  It was my
pleasure to contribute this miniscule addition to the wonderful emacs.

On Sat, Jan 29, 2022, 6:49 PM J.P. <jp <at> neverwas.me> wrote:

> Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:
>
> > Here it is. I don't think my pgp key is on any keyserver, but I signed
> > it anyway.
>
> I'm not sure if Emacs has a policy regarding the signing of everyday
> contributions, but if your key isn't signed by anyone and not propagated
> among the keyservers, then I'd guess you can probably just skip further
> signing in the near term.
>
> > Thank you for the encouragement.
>
> My pleasure. This looks ready for Emacs 29. Thanks.
>
>                               . . .
>
> I've added the customary tweaks to the log message if someone wants to
> glance at it (cc. bandali, Lars). Also, question: is there formal
> recordkeeping going on re exempt lines accumulated per individual? And
> if not, is the recommended way to get a tally just `git log --author=`?
>
>

[Message part 2 (text/html, inline)]

Message #28 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "J.P." <jp <at> neverwas.me>
Cc: strings.stringsandstrings <at> gmail.com, larsi <at> gnus.org, emacs-erc <at> gnu.org,
 bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sun, 30 Jan 2022 08:34:08 +0200

> From: "J.P." <jp <at> neverwas.me>
> Date: Sat, 29 Jan 2022 15:49:24 -0800
> Cc: larsi <at> gnus.org, emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
> 
> Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:
> 
> > Here it is. I don't think my pgp key is on any keyserver, but I signed
> > it anyway.
> 
> I'm not sure if Emacs has a policy regarding the signing of everyday
> contributions

It does.  From CONTRIBUTE:

  - Commit messages should not contain the "Signed-off-by:" lines that
    are used in some other projects.

> I've added the customary tweaks to the log message if someone wants to
> glance at it (cc. bandali, Lars). Also, question: is there formal
> recordkeeping going on re exempt lines accumulated per individual? And
> if not, is the recommended way to get a tally just `git log --author=`?

I don't think I understand what you are asking here, please elaborate.

Message #31 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: strings.stringsandstrings <at> gmail.com, larsi <at> gnus.org, emacs-erc <at> gnu.org,
 bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sun, 30 Jan 2022 07:43:37 -0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> I'm not sure if Emacs has a policy regarding the signing of everyday
>> contributions
>
> It does.  From CONTRIBUTE:
>
>   - Commit messages should not contain the "Signed-off-by:" lines that
>     are used in some other projects.

Thanks. I could certainly use a good reread of CONTRIBUTE. I guess in
this case, I was more confused about what role a PGP-signed patch (like
the OP's) could ever play in workflows that incorporate PGP commit
signing and whether Emacs had a stance on that sort of signing in
general. The first part (I now realize) makes little sense because it's
only committers who sign commits. And so a PGP-signed patch (like a
PGP-signed email) can only get as far as the bug tracker. As for the
second part, PGP-signed commits appear to be relatively rare in Emacs.
Among the most recent 10K or so commits reachable from HEAD, it seems
only around 1% have been signed (list attached).

>> Also, question: is there formal recordkeeping going on re exempt
>> lines accumulated per individual? And if not, is the recommended way
>> to get a tally just `git log --author=`?
>
> I don't think I understand what you are asking here, please elaborate.

Apologies for the unintelligible mumblage. Somehow (believe it or not),
I was trying to ask whether there's a system in place for keeping track
of the number of non-trivial changes a non-paperwork holder has made so
far. By "system" I guess I mean a person in charge of recording such
information or perhaps a table somewhere to consult. But if it's less
formal than all that, I suppose I'll just rely on the git history and
whatever an author self-reports. Thanks.

[recently-signed.log (text/plain, attachment)]

Message #34 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "J.P." <jp <at> neverwas.me>
Cc: strings.stringsandstrings <at> gmail.com, Eli Zaretskii <eliz <at> gnu.org>,
 emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sun, 30 Jan 2022 17:00:25 +0100

"J.P." <jp <at> neverwas.me> writes:

> Apologies for the unintelligible mumblage. Somehow (believe it or not),
> I was trying to ask whether there's a system in place for keeping track
> of the number of non-trivial changes a non-paperwork holder has made so
> far. By "system" I guess I mean a person in charge of recording such
> information or perhaps a table somewhere to consult. But if it's less
> formal than all that, I suppose I'll just rely on the git history and
> whatever an author self-reports. Thanks.

No, we don't have such a system, unfortunately.  It's somewhat
subjective what counts -- we try to count "lines of code", so whitespace
changes don't count, of course, and other trivial transforms don't count
either.

So as you say -- you just have to look at the commit history and make a
judgement call in these cases.  (Or even better, ask for a copyright
assignment form and then you don't have to count. 😀)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, emacs-erc <at> gnu.org, bandali <at> gnu.org,
 53617 <at> debbugs.gnu.org, "J.P." <jp <at> neverwas.me>
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sun, 30 Jan 2022 11:25:05 -0500

[Message part 1 (text/plain, inline)]

Yeah, I have no problem with the copyright assignment.  I will look in the
docs to see what I need to give you all for it.

On Sun, Jan 30, 2022 at 11:00 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> "J.P." <jp <at> neverwas.me> writes:
>
> > Apologies for the unintelligible mumblage. Somehow (believe it or not),
> > I was trying to ask whether there's a system in place for keeping track
> > of the number of non-trivial changes a non-paperwork holder has made so
> > far. By "system" I guess I mean a person in charge of recording such
> > information or perhaps a table somewhere to consult. But if it's less
> > formal than all that, I suppose I'll just rely on the git history and
> > whatever an author self-reports. Thanks.
>
> No, we don't have such a system, unfortunately.  It's somewhat
> subjective what counts -- we try to count "lines of code", so whitespace
> changes don't count, of course, and other trivial transforms don't count
> either.
>
> So as you say -- you just have to look at the commit history and make a
> judgement call in these cases.  (Or even better, ask for a copyright
> assignment form and then you don't have to count. 😀)
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[Message part 2 (text/html, inline)]

Message #40 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: Michael Olson <mwolson <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: emacs-erc <at> gnu.org, bandali <at> gnu.org, "J.P." <jp <at> neverwas.me>,
 53617 <at> debbugs.gnu.org, strings.stringsandstrings <at> gmail.com,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sun, 30 Jan 2022 22:22:05 -0500

[Message part 1 (text/plain, inline)]

On Sun, Jan 30, 2022 at 11:00 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> "J.P." <jp <at> neverwas.me> writes:
>
> > Apologies for the unintelligible mumblage. Somehow (believe it or not),
> > I was trying to ask whether there's a system in place for keeping track
> > of the number of non-trivial changes a non-paperwork holder has made so
> > far. By "system" I guess I mean a person in charge of recording such
> > information or perhaps a table somewhere to consult. But if it's less
> > formal than all that, I suppose I'll just rely on the git history and
> > whatever an author self-reports. Thanks.
>
> No, we don't have such a system, unfortunately.  It's somewhat
> subjective what counts -- we try to count "lines of code", so whitespace
> changes don't count, of course, and other trivial transforms don't count
> either.


What I'd sometimes do 10+ years ago is keep an AUTHORS file with a list of
who contributed, which files, and (in the case of unassigned contributors)
how many lines so I knew if they were getting close to the limit. I'm not
sure if that would map well to the Emacs repo, maybe a side file like
ERC-AUTHORS, or just kept outside of the repo.

[Message part 2 (text/html, inline)]

Message #43 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emanuel Berg <moasenwood <at> zoho.eu>
To: bug-gnu-emacs <at> gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Mon, 31 Jan 2022 04:38:00 +0100

>>> No, we don't have such a system, unfortunately.
>>> It's somewhat subjective what counts -- we try to count
>>> "lines of code", so whitespace changes don't count, of
>>> course, and other trivial transforms don't count either.
>>
>> What I'd sometimes do 10+ years ago is keep an AUTHORS file
>> with a list of who contributed, which files, and (in the
>> case of unassigned contributors) how many lines so I knew if
>> they were getting close to the limit. I'm not sure if that
>> would map well to the Emacs repo, maybe a side file like
>> ERC-AUTHORS, or just kept outside of the repo.
>
> I've seen a git command do something similar for the Emacs
> source ... posted on gmane.emacs.help not so long ago.

Didn't find it, but I think it was this:

$ git shortlog -s --all | sort -n -r | head -n 10
 20708	Richard M. Stallman
 12586	Glenn Morris
 11454	Eli Zaretskii
  9153	Stefan Monnier
  6786	Kenichi Handa
  6601	Paul Eggert
  6056	Chong Yidong
  5019	Gerd Moellmann
  4703	Juanma Barranquero
  4049	Lars Ingebrigtsen

-- 
underground experts united
https://dataswamp.org/~incal

Message #46 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emanuel Berg <moasenwood <at> zoho.eu>
To: bug-gnu-emacs <at> gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Mon, 31 Jan 2022 04:30:30 +0100

Michael Olson wrote:

>>> Apologies for the unintelligible mumblage.
>>> Somehow (believe it or not), I was trying to ask whether
>>> there's a system in place for keeping track of the number
>>> of non-trivial changes a non-paperwork holder has made so
>>> far. By "system" I guess I mean a person in charge of
>>> recording such information or perhaps a table somewhere to
>>> consult. But if it's less formal than all that, I suppose
>>> I'll just rely on the git history and whatever an author
>>> self-reports. Thanks.
>>
>> No, we don't have such a system, unfortunately.
>> It's somewhat subjective what counts -- we try to count
>> "lines of code", so whitespace changes don't count, of
>> course, and other trivial transforms don't count either.
>
> What I'd sometimes do 10+ years ago is keep an AUTHORS file
> with a list of who contributed, which files, and (in the
> case of unassigned contributors) how many lines so I knew if
> they were getting close to the limit. I'm not sure if that
> would map well to the Emacs repo, maybe a side file like
> ERC-AUTHORS, or just kept outside of the repo.

I've seen a git command do something similar for the Emacs
source ... posted on gmane.emacs.help not so long ago.

-- 
underground experts united
https://dataswamp.org/~incal

Message #49 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Michael Olson <mwolson <at> gnu.org>
Cc: emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org,
 strings.stringsandstrings <at> gmail.com, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sun, 30 Jan 2022 21:35:08 -0800

Michael Olson <mwolson <at> gnu.org> writes:

> What I'd sometimes do 10+ years ago is keep an AUTHORS file with a
> list of who contributed, which files, and (in the case of unassigned
> contributors) how many lines so I knew if they were getting close to
> the limit. I'm not sure if that would map well to the Emacs repo,
> maybe a side file like ERC-AUTHORS, or just kept outside of the repo.

Hi Michael (such an honor to hear from a true ERC OG!),

In the case of an unassigned contributor (a term I'm stealing BTW
because it's vastly superior to my unpronounceable "non-paperwork
holder"), I guess we'd still have to keep tabs on contributions across
*all* of Emacs. But as a starting point for a more intensive inquiry,
it's a fine solution. And I guess we'd likely just leave that sort of
thing outside the repo, for now. Anyway, thanks so much for your
insights and for all your work back in the day! (And also to Lars for
the low down/lay of the land.)

Message #52 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Olson <mwolson <at> gnu.org>
Cc: emacs-erc <at> gnu.org, bandali <at> gnu.org, jp <at> neverwas.me, 53617 <at> debbugs.gnu.org,
 strings.stringsandstrings <at> gmail.com, larsi <at> gnus.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Mon, 31 Jan 2022 14:31:06 +0200

> From: Michael Olson <mwolson <at> gnu.org>
> Date: Sun, 30 Jan 2022 22:22:05 -0500
> Cc: "J.P." <jp <at> neverwas.me>, strings.stringsandstrings <at> gmail.com, 
> 	Eli Zaretskii <eliz <at> gnu.org>, emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
> 
> What I'd sometimes do 10+ years ago is keep an AUTHORS file with a list of who contributed, which files,
> and (in the case of unassigned contributors) how many lines so I knew if they were getting close to the limit.
> I'm not sure if that would map well to the Emacs repo, maybe a side file like ERC-AUTHORS, or just kept
> outside of the repo.

This is very tedious, and moreover, ephemeral: the threshold of a
dozen or so non-trivial lines is crossed only once and usually very
quickly; once it is crossed, it can never be crossed back (well,
except in the rare case that a person changes employers and is again
without an assignment).  So this kind of bookkeeping requires a lot of
clerical  work for little or no gain.

Message #55 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
Cc: larsi <at> gnus.org, emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Mon, 14 Mar 2022 06:33:48 -0700

[Message part 1 (text/plain, inline)]

"J.P." <jp <at> neverwas.me> writes:

> I've added the customary tweaks to the log message if someone wants to
> glance at it (cc. bandali, Lars).

This now includes a unit test.

Unless anyone objects or I'm preempted, I'll add this to 29 on or around
March 19th (~5 days from now), and leave ERC's version number unchanged
at 5.4.1. Thanks.

[0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch (text/x-patch, attachment)]

[0002-DROP-ME-Add-eventual-unit-test-for-erc-switch-to-buf.patch (text/x-patch, attachment)]

Message #58 received at 53617 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
Cc: larsi <at> gnus.org, emacs-erc <at> gnu.org, bandali <at> gnu.org, 53617 <at> debbugs.gnu.org
Subject: Re: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Sat, 19 Mar 2022 03:08:54 -0700

"J.P." <jp <at> neverwas.me> writes:

> This now includes a unit test.

Sorry about the test failure, people. Fixed now (^_^;) [1].

> Unless anyone objects or I'm preempted, I'll add this to 29 on or
> around March 19th

Done. Thanks. Closing.

P.S. Guy, when you get your paperwork sorted, don't forget about ERC!


[1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2f1fbf20
    https://emba.gnu.org/emacs/emacs/-/jobs/41710

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.