GNU bug report logs - #53617
28.0.90; duplicate checks in erc--switch-to-buffer

Previous Next

Full log

View this message in rfc822 format

From: "J.P." <jp <at> neverwas.me>
To: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
Cc: 53617 <at> debbugs.gnu.org, emacs-erc <at> gnu.org
Subject: bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 19:07:43 -0800

Hi Guy,

Thanks for following through with the report.

Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:

> The entire sexp starting with `with-current-buffer ...` can be removed
> without changing the semantics of erc--switch-to-buffer.

You're right, of course. In fact, the same commit that introduced
`erc--buffer-p' added the redundancy as well [1]. It looks like they saw
an opportunity to factor out that predicate and simply forgot to erase
the last of what they'd just obsoleted.

Are you sure you're not into cloning the repo and saving out a patch? No
worries if not. This is great regardless.

Thanks again,
J.P.


[1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.