GNU bug report logs - #53617
28.0.90; duplicate checks in erc--switch-to-buffer

Previous Next

Full log

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Guy Gastineau <strings.stringsandstrings <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: bug-gnu-emacs <at> gnu.org, emacs-erc <at> gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 22:13:41 -0500

[Message part 1 (text/plain, inline)]

Sure. I will do it.  The emacs bug report buffer provided access to a help
page.  It suggested I make a patch with `diff -u`.  Is it preferable to
provide a patch as made with git?

On Fri, Jan 28, 2022, 10:07 PM J.P. <jp <at> neverwas.me> wrote:

> Hi Guy,
>
> Thanks for following through with the report.
>
> Guy Gastineau <strings.stringsandstrings <at> gmail.com> writes:
>
> > The entire sexp starting with `with-current-buffer ...` can be removed
> > without changing the semantics of erc--switch-to-buffer.
>
> You're right, of course. In fact, the same commit that introduced
> `erc--buffer-p' added the redundancy as well [1]. It looks like they saw
> an opportunity to factor out that predicate and simply forgot to erase
> the last of what they'd just obsoleted.
>
> Are you sure you're not into cloning the repo and saving out a patch? No
> worries if not. This is great regardless.
>
> Thanks again,
> J.P.
>
>
> [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.