GNU bug report logs - #53525
[PATCH] gnu: Add emacs-puni

Previous Next

Full log

Message #8 received at 53525 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 53525 <at> debbugs.gnu.org
Subject: Re: [bug#53525] [PATCH] gnu: Add emacs-puni
Date: Tue, 25 Jan 2022 18:09:06 +0100

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-puni

Thank you.

> +(define-public emacs-puni
> +  ;; No tagged release upstream
> +  (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))

Nitpick: could you add a newline character between (commit ...) and
(revision ...)?

> +      (home-page "https://github.com/AmaiKinono/puni")
> +      (synopsis "Parentheses Universalistic")

This synopsis is not very useful. Could you expound it a bit?
> +      (description
> +       "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")

Description are expected to consist of full sentences. I suggest:

   Puni is an Emacs minor mode for structured editing: soft deletion,
   expression navigating and manipulating.  It supports many major modes
   out of the box.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.