GNU bug report logs - #53525
[PATCH] gnu: Add emacs-puni

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53525 in the body.
You can then email your comments to 53525 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-puni
Date: Tue, 25 Jan 2022 16:46:07 +0000

[Message part 1 (text/plain, inline)]

Hi,

this patch adds the Emacs puni package.

/Niklas

[0001-gnu-Add-emacs-puni.patch (text/x-patch, attachment)]

Message #8 received at 53525 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 53525 <at> debbugs.gnu.org
Subject: Re: [bug#53525] [PATCH] gnu: Add emacs-puni
Date: Tue, 25 Jan 2022 18:09:06 +0100

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Subject: [PATCH] gnu: Add emacs-puni

Thank you.

> +(define-public emacs-puni
> +  ;; No tagged release upstream
> +  (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))

Nitpick: could you add a newline character between (commit ...) and
(revision ...)?

> +      (home-page "https://github.com/AmaiKinono/puni")
> +      (synopsis "Parentheses Universalistic")

This synopsis is not very useful. Could you expound it a bit?
> +      (description
> +       "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")

Description are expected to consist of full sentences. I suggest:

   Puni is an Emacs minor mode for structured editing: soft deletion,
   expression navigating and manipulating.  It supports many major modes
   out of the box.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 53525 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 53525 <at> debbugs.gnu.org
Subject: Re: [bug#53525] [PATCH] gnu: Add emacs-puni
Date: Tue, 25 Jan 2022 17:18:13 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund <at> posteo.net> writes:
>
>> Subject: [PATCH] gnu: Add emacs-puni
>
> Thank you.
>
>> +(define-public emacs-puni
>> +  ;; No tagged release upstream
>> +  (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
>
> Nitpick: could you add a newline character between (commit ...) and
> (revision ...)?

Oops, how did that end up there, of course!

>> +      (home-page "https://github.com/AmaiKinono/puni")
>> +      (synopsis "Parentheses Universalistic")
>
> This synopsis is not very useful. Could you expound it a bit?

Will give it a go :)

>> +      (description
>> +       "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")
>
> Description are expected to consist of full sentences. I suggest:
>
>    Puni is an Emacs minor mode for structured editing: soft deletion,
>    expression navigating and manipulating.  It supports many major modes
>    out of the box.
>
> Could you send an updated patch?
>
> Regards,
> -- 
> Nicolas Goaziou

Absolutely, thanks for the feedback :)

Here is an updated patch.

Best regards,

Niklas

[0001-gnu-Add-emacs-puni.patch (text/x-patch, attachment)]

Message #16 received at 53525-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund <at> posteo.net>
Cc: 53525-done <at> debbugs.gnu.org
Subject: Re: [bug#53525] [PATCH] gnu: Add emacs-puni
Date: Tue, 25 Jan 2022 21:53:24 +0100

Hello,

Niklas Eklund <niklas.eklund <at> posteo.net> writes:

> Here is an updated patch.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.