GNU bug report logs - #53525
[PATCH] gnu: Add emacs-puni

Previous Next

Full log

View this message in rfc822 format

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 53525 <at> debbugs.gnu.org
Subject: [bug#53525] [PATCH] gnu: Add emacs-puni
Date: Tue, 25 Jan 2022 17:18:13 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund <at> posteo.net> writes:
>
>> Subject: [PATCH] gnu: Add emacs-puni
>
> Thank you.
>
>> +(define-public emacs-puni
>> +  ;; No tagged release upstream
>> +  (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0"))
>
> Nitpick: could you add a newline character between (commit ...) and
> (revision ...)?

Oops, how did that end up there, of course!

>> +      (home-page "https://github.com/AmaiKinono/puni")
>> +      (synopsis "Parentheses Universalistic")
>
> This synopsis is not very useful. Could you expound it a bit?

Will give it a go :)

>> +      (description
>> +       "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.")
>
> Description are expected to consist of full sentences. I suggest:
>
>    Puni is an Emacs minor mode for structured editing: soft deletion,
>    expression navigating and manipulating.  It supports many major modes
>    out of the box.
>
> Could you send an updated patch?
>
> Regards,
> -- 
> Nicolas Goaziou

Absolutely, thanks for the feedback :)

Here is an updated patch.

Best regards,

Niklas

[0001-gnu-Add-emacs-puni.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.