GNU bug report logs - #5305
[patch] add defined-colors-with-face-attributes to faces.el

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Moringen <jan.moringen <at> uni-bielefeld.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [patch] add defined-colors-with-face-attributes to faces.el
Date: Sun, 03 Jan 2010 22:02:31 +0100

[Message part 1 (text/plain, inline)]

Hi,

in an application I wrote, the user is prompted for a color using
`read-color'. The completion table used there presents color names.
However, based on color names alone, I often found it hard to choose a
color. Therefore I wrote `defined-colors-with-face-attributes' which
is
like `defined-colors' but adds text properties to the color names that
make them render with the color they name as background. I also
changed
`read-color' to call the new function when a color display is
available.

I have tested the new behavior on X displays and TTYs and it seems to
work. However, I could not test windows or other terminal types and/or
other color depths.

If this change is considered useful, I would like to contribute it. I
have done the copyright assignment for Emacs.

Kind regards,
Jan

[read-color-99203-merge-directive.txt (text/plain, attachment)]

[read-color-99203.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.