GNU bug report logs - #5305
[patch] add defined-colors-with-face-attributes to faces.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5305 in the body.
You can then email your comments to 5305 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Moringen <jan.moringen <at> uni-bielefeld.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [patch] add defined-colors-with-face-attributes to faces.el
Date: Sun, 03 Jan 2010 22:02:31 +0100

[Message part 1 (text/plain, inline)]

Hi,

in an application I wrote, the user is prompted for a color using
`read-color'. The completion table used there presents color names.
However, based on color names alone, I often found it hard to choose a
color. Therefore I wrote `defined-colors-with-face-attributes' which
is
like `defined-colors' but adds text properties to the color names that
make them render with the color they name as background. I also
changed
`read-color' to call the new function when a color display is
available.

I have tested the new behavior on X displays and TTYs and it seems to
work. However, I could not test windows or other terminal types and/or
other color depths.

If this change is considered useful, I would like to contribute it. I
have done the copyright assignment for Emacs.

Kind regards,
Jan

[read-color-99203-merge-directive.txt (text/plain, attachment)]

[read-color-99203.patch (text/x-patch, attachment)]

Message #12 received at 5305 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jan Moringen <jan.moringen <at> uni-bielefeld.de>
Cc: 5305 <at> debbugs.gnu.org
Subject: Re: bug#5305: [patch] add defined-colors-with-face-attributes to
 faces.el
Date: Sun, 28 Feb 2016 17:30:30 +1100

Jan Moringen <jan.moringen <at> uni-bielefeld.de> writes:

> in an application I wrote, the user is prompted for a color using
> `read-color'. The completion table used there presents color names.
> However, based on color names alone, I often found it hard to choose a
> color. Therefore I wrote `defined-colors-with-face-attributes' which
> is
> like `defined-colors' but adds text properties to the color names that
> make them render with the color they name as background. I also
> changed
> `read-color' to call the new function when a color display is
> available.
>
> I have tested the new behavior on X displays and TTYs and it seems to
> work. However, I could not test windows or other terminal types and/or
> other color depths.

I like it a lot, so I've applied it to the Emacs trunk.  All the colour
combinations were legible on my screen, but perhaps some people have
screens where they may be less so, but I guess we'll find out.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 5305 <at> debbugs.gnu.org (full text, mbox):

From: Jan Moringen <jmoringe <at> techfak.uni-bielefeld.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Jan Moringen
 <jan.moringen <at> uni-bielefeld.de>
Cc: 5305 <at> debbugs.gnu.org
Subject: Re: bug#5305: [patch] add defined-colors-with-face-attributes to
 faces.el
Date: Sun, 28 Feb 2016 14:07:35 +0100

On Sun, 2016-02-28 at 17:30 +1100, Lars Ingebrigtsen wrote:
> Jan Moringen <jan.moringen <at> uni-bielefeld.de> writes:
> 
> > ...
>
> I like it a lot, so I've applied it to the Emacs trunk.  All the
> colour
> combinations were legible on my screen, but perhaps some people have
> screens where they may be less so, but I guess we'll find out.

Thanks for applying this, but http://git.savannah.gnu.org/cgit/emacs.gi
t/commit/?id=8ed026d6176d02412b6c48d9dfbd9f3a345a86a6 seems to show
duplicate definitions of the new functions. Maybe something went wrong
with applying the patch?

Kind regards,
Jan

Message #22 received at 5305 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jan Moringen <jmoringe <at> techfak.uni-bielefeld.de>
Cc: 5305 <at> debbugs.gnu.org, Jan Moringen <jan.moringen <at> uni-bielefeld.de>
Subject: Re: bug#5305: [patch] add defined-colors-with-face-attributes to
 faces.el
Date: Mon, 29 Feb 2016 13:32:30 +1100

Jan Moringen <jmoringe <at> techfak.uni-bielefeld.de> writes:

> Thanks for applying this, but http://git.savannah.gnu.org/cgit/emacs.gi
> t/commit/?id=8ed026d6176d02412b6c48d9dfbd9f3a345a86a6 seems to show
> duplicate definitions of the new functions. Maybe something went wrong
> with applying the patch?

Thanks for noticing; I've now remove the duplicates.  I must have
applied (parts of) the patch twice or something?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.