GNU bug report logs - #53039
[PATCH] build-system/python: Change let* to let.

Previous Next

Full log

Message #13 received at 53039-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 53039-done <at> debbugs.gnu.org
Subject: Re: bug#53039: [PATCH] build-system/python: Change let* to let.
Date: Wed, 18 May 2022 09:06:58 -0400

Hi,

jgart <jgart <at> dismail.de> writes:

> * guix/build/python-build-system.scm (site-packages): Change let* to let for
> readability and since let* is unused.
> ---
>  guix/build/python-build-system.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 08871f60cd..a9b1c74f63 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -11,6 +11,7 @@
>  ;;; Copyright © 2020 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2021 Lars-Dominik Braun <lars <at> 6xq.net>
>  ;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
> +;;; Copyright © 2022 jgart <jgart <at> dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -176,8 +177,8 @@ (define (python-output outputs)
>  
>  (define (site-packages inputs outputs)
>    "Return the path of the current output's Python site-package."
> -  (let* ((out (python-output outputs))
> -         (python (assoc-ref inputs "python")))
> +  (let ((out (python-output outputs))
> +        (python (assoc-ref inputs "python")))
>      (string-append out "/lib/python" (python-version python) "/site-packages")))
>  
>  (define (add-installed-pythonpath inputs outputs)

As Maxime mentioned, that should go to core-updates.  It's nice to use
the --subject-prefix option of 'git format-patch' to change it to
"[PATCH core-updates]", so that we don't apply these mistakenly to
master and cause world rebuilds :-)

Another note; only changes of minimally 10 lines are copyrightable, so
you do not need to add a copyright attribution for trivial changes such
as this one.

I've made the change to core-updates and committed as 47fac5dc59; closing.

Thank you!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.