GNU bug report logs - #53040
[PATCH] gnu: bubblewrap: Update to 0.5.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53040 in the body.
You can then email your comments to 53040 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <at> tutanota.com
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Wed, 5 Jan 2022 23:54:23 +0100 (CET)

[Message part 1 (text/plain, inline)]

Unfortunately some tests fail because of missing locales, I've attached the test log. Help is appreciated.

[0001-gnu-bubblewrap-Update-to-0.5.0.patch (text/x-patch, attachment)]

[test-suite.log (text/x-log, attachment)]

Message #8 received at 53040 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: kiasoc5 <at> tutanota.com
Cc: 53040 <at> debbugs.gnu.org
Subject: Re: bug#53040: [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Sun, 09 Jan 2022 22:50:04 +0100

Hi,

kiasoc5 <at> tutanota.com skribis:

> ERROR: tests/test-specifying-pidns.sh
> =====================================
>
> +++ dirname ./tests/test-specifying-pidns.sh
> ++ cd ./tests
> ++ pwd
> + srcd=/tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests
> + . /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests/libtest.sh
> ++ set -e
> ++ '[' -n /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0 ']'
> ++ test_srcdir=/tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests
> ++ '[' -n /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0 ']'
> ++ test_builddir=/tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests
> ++ . /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests/libtest-core.sh
> +++ type -p locale
> ++++ locale -a
> ++++ grep -iEe '^(C|en_US)\.(UTF-8|utf8)$'

The ‘en_US.utf8’ locale is available; however, the ‘locale -a’ command
won’t list it, for obscure reasons.

I suggest patching libtest-core.sh so that it unconditionally uses
en_US.utf8 instead of running ‘locale -a’.

HTH!

Ludo’.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <at> tutanota.com
To: Guix Patches <guix-patches <at> gnu.org>
Cc: ludo <at> gnu.org
Subject: Re: [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Tue, 11 Jan 2022 00:14:19 +0100 (CET)

[Message part 1 (text/plain, inline)]

Fixed locale in tests, thanks Ludo for the suggestion via email. Also fixed more test substitutions and simplified inputs.

[0001-gnu-bubblewrap-Update-to-0.5.0.patch (text/x-patch, attachment)]

Message #14 received at 53040 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: kiasoc5 <at> tutanota.com
Cc: 53040 <at> debbugs.gnu.org
Subject: Re: bug#53040: [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Tue, 11 Jan 2022 18:52:42 +0100

Hi,

kiasoc5 <at> tutanota.com skribis:

> Fixed locale in tests, thanks Ludo for the suggestion via email. Also fixed more test substitutions and simplified inputs.
>
>>From f5c56100d62d315c3ed860898998a7c8afc78d50 Mon Sep 17 00:00:00 2001
> From: kiasoc5 <kiasoc5 <at> tutanota.com>
> Date: Mon, 10 Jan 2022 17:58:35 -0500
> Subject: [PATCH] gnu: bubblewrap: Update to 0.5.0.
>
> * gnu/packages/patches/bubblewrap-fix-locale-in-tests.patch: Add it.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/virtualization.scm (bubblewrap): Update to 0.5.0.
> [source]: Add patch.
> [arguments]: Adjust test substitutions.
> [inputs]: Remove labels.
> [native-inputs]: Remove labels.

That LGTM.  I tested direct dependents as shown by:

  ./pre-inst-env guix graph -M1 -t reverse-package bubblewrap | xdot -f fdp -

Unfortunately, the update breaks flatpak (both 1.12.1 and 1.12.2):

--8<---------------cut here---------------start------------->8---
make[3]: Nothing to be done for 'tests/org.flatpak.Authenticator.test.service.in'.
rm -rf tests/runtime-repo
PATH=/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2:${PATH} ./tests/make-test-runtime.sh tests/runtime-repo org.test.Platform master "" ""
guix
error: Writing content object: min-free-space-percent '3%' would be exceeded, at least 36.9 kB requested
make[3]: *** [Makefile:7804: tests/runtime-repo] Error 1
make[3]: Leaving directory '/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2'
make[2]: *** [Makefile:7063: check-am] Error 2
make[2]: Leaving directory '/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2'
make[1]: *** [Makefile:6255: check-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2'
make: *** [Makefile:7067: check] Error 2
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("check" "TESTS=tests/test-basic.sh tests/test-config.sh testcommon") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `check' failed after 17.2 seconds
command "make" "check" "TESTS=tests/test-basic.sh tests/test-config.sh testcommon" failed with status 2
--8<---------------cut here---------------end--------------->8---

Could you take a look?

Apologies for the extra work!

Thanks,
Ludo’.

Message #17 received at 53040 <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <at> tutanota.com
To: Ludovic Courtès <ludo <at> gnu.org>, 53040 <at> debbugs.gnu.org
Subject: Re: bug#53040: [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Tue, 11 Jan 2022 22:46:40 +0100 (CET)

[Message part 1 (text/plain, inline)]

I rebased the patch onto today's Guix commits, and Flatpak 1.12.1 and 1.12.2 passes the tests on my machine. But I'm currently running Guix on Arch and don't have a Guix system available to test further.

All dependent packages except wpewebkit build successfully. wpewebkit build log complains during cmake configuration that a required package is not found, but it seems unrelated to bubblewrap, and it won't build on master anyways.

Jan 11, 2022, 17:52 by ludo <at> gnu.org:

> Hi,
>
> kiasoc5 <at> tutanota.com skribis:
>
>> Fixed locale in tests, thanks Ludo for the suggestion via email. Also fixed more test substitutions and simplified inputs.
>>
> >>From f5c56100d62d315c3ed860898998a7c8afc78d50 Mon Sep 17 00:00:00 2001
>
>> From: kiasoc5 <kiasoc5 <at> tutanota.com>
>> Date: Mon, 10 Jan 2022 17:58:35 -0500
>> Subject: [PATCH] gnu: bubblewrap: Update to 0.5.0.
>>
>> * gnu/packages/patches/bubblewrap-fix-locale-in-tests.patch: Add it.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>> * gnu/packages/virtualization.scm (bubblewrap): Update to 0.5.0.
>> [source]: Add patch.
>> [arguments]: Adjust test substitutions.
>> [inputs]: Remove labels.
>> [native-inputs]: Remove labels.
>>
>
> That LGTM.  I tested direct dependents as shown by:
>
> ./pre-inst-env guix graph -M1 -t reverse-package bubblewrap | xdot -f fdp -
>
> Unfortunately, the update breaks flatpak (both 1.12.1 and 1.12.2):
>
> --8<---------------cut here---------------start------------->8---
> make[3]: Nothing to be done for 'tests/org.flatpak.Authenticator.test.service.in'.
> rm -rf tests/runtime-repo
> PATH=/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2:${PATH} ./tests/make-test-runtime.sh tests/runtime-repo org.test.Platform master "" ""
> guix
> error: Writing content object: min-free-space-percent '3%' would be exceeded, at least 36.9 kB requested
> make[3]: *** [Makefile:7804: tests/runtime-repo] Error 1
> make[3]: Leaving directory '/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2'
> make[2]: *** [Makefile:7063: check-am] Error 2
> make[2]: Leaving directory '/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2'
> make[1]: *** [Makefile:6255: check-recursive] Error 1
> make[1]: Leaving directory '/tmp/guix-build-flatpak-1.12.2.drv-0/flatpak-1.12.2'
> make: *** [Makefile:7067: check] Error 2
> error: in phase 'check': uncaught exception:
> %exception #<&invoke-error program: "make" arguments: ("check" "TESTS=tests/test-basic.sh tests/test-config.sh testcommon") exit-status: 2 term-signal: #f stop-signal: #f> 
> phase `check' failed after 17.2 seconds
> command "make" "check" "TESTS=tests/test-basic.sh tests/test-config.sh testcommon" failed with status 2
> --8<---------------cut here---------------end--------------->8---
>
> Could you take a look?
>
> Apologies for the extra work!
>
> Thanks,
> Ludo’.
>

[0001-gnu-bubblewrap-Update-to-0.5.0.patch (text/x-patch, attachment)]

Message #20 received at 53040 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>, kiasoc5 <at> tutanota.com
Cc: 53040 <at> debbugs.gnu.org
Subject: Re: [bug#53040] [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Wed, 12 Jan 2022 17:42:53 +0100

Hello Ludovic and kiasoc5, 

Ludovic Courtès <ludo <at> gnu.org> writes:
> The ‘en_US.utf8’ locale is available; however, the ‘locale -a’ command
> won’t list it, for obscure reasons.
>
> I suggest patching libtest-core.sh so that it unconditionally uses
> en_US.utf8 instead of running ‘locale -a’.

I am a bit late to the party, but the official locale name is
en_US.UTF-8.  utf8 is not a registered IANA name.  UTF-8 is converted to
utf8 by glibc internally, but I remember having issues when I had
mistakenly set LC_ALL to en_US.utf8 in the past, so better be safe than
sorry.

-- 
Josselin Poiret

Message #25 received at 53040-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: kiasoc5 <at> tutanota.com
Cc: 53040-done <at> debbugs.gnu.org
Subject: Re: bug#53040: [PATCH] gnu: bubblewrap: Update to 0.5.0.
Date: Thu, 13 Jan 2022 22:55:13 +0100

Hi,

kiasoc5 <at> tutanota.com skribis:

> I rebased the patch onto today's Guix commits, and Flatpak 1.12.1 and 1.12.2 passes the tests on my machine. But I'm currently running Guix on Arch and don't have a Guix system available to test further.

Indeed, I tried on a newer machine and it went fine (the one I was
building on previously is really old and I suspect an odd
hardware-related issue.)

> All dependent packages except wpewebkit build successfully. wpewebkit build log complains during cmake configuration that a required package is not found, but it seems unrelated to bubblewrap, and it won't build on master anyways.

Noted.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.