GNU bug report logs - #52803
[PATCH] gnu: Add headsetcontrol.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: John Kehayias <john.kehayias <at> protonmail.com>
Subject: bug#52803: closed (Re: [bug#52803] [PATCH v2] gnu: Add
 headsetcontrol.)
Date: Mon, 27 Dec 2021 09:51:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#52803: [PATCH] gnu: Add headsetcontrol.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 52803 <at> debbugs.gnu.org.

-- 
52803: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52803
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Cc: John Kehayias <john.kehayias <at> pm.me>,
 "52803 <at> debbugs.gnu.org" <52803-done <at> debbugs.gnu.org>
Subject: Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.
Date: Mon, 27 Dec 2021 10:49:57 +0100

Hello,

John Kehayias via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add headsetcontrol.
>
> * gnu/packages/hardware.scm (headsetcontrol): New variable.

Thank you. I pushed it with the changes detailed below.

> +(define-public headsetcontrol
> +  (package
> +    (name "headsetcontrol")
> +    (version "2.6")
> +    (source (origin
> +             (method git-fetch)

I moved `origin' below `source' and adjusted indentation.

> +             (uri (git-reference
> +                   (url "https://github.com/Sapd/HeadsetControl")
> +                   (commit version)))
> +             (file-name (git-file-name name version))
> +             (sha256
> +              (base32
> +               "0a7zimzi71416pmn6z0l1dn1c2x8p702hkd0k6da9rsznff85a88"))))

I moved hash on the same line as `base32'

> +    (build-system cmake-build-system)
> +    (inputs
> +      (list hidapi))
> +    (synopsis "Sidetone and Battery status for USB headsets")
> +    (description
> +      "A tool to control certain aspects of USB-connected headsets on Linux.

I started the description with the name of the package (guix lint
should warn you about this), and removed reference to Linux, since it is
not useful in Guix.

> +Currently, support is provided for adjusting sidetone, getting battery state,
> +controlling LEDs, and setting the inactive time.")
> +    (home-page "https://github.com/Sapd/HeadsetControl")
> +    (license license:gpl3)))

I used gpl3+ as "main.c" includes "or (at your option) any later
version" in its header.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add headsetcontrol.
Date: Sun, 26 Dec 2021 16:16:13 +0000

[Message part 4 (text/plain, inline)]

Attached is a patch to add the program headsetcontrol, which allows getting/setting properties for USB headsets. I've been using a previous version (2.4) locally for quite some time and it works well.

The package also builds udev rules, should a note be added to the description that it includes udev rules or anything about that?

Thanks!

John

[0001-gnu-Add-headsetcontrol.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.