GNU bug report logs - #52803
[PATCH] gnu: Add headsetcontrol.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52803 in the body.
You can then email your comments to 52803 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add headsetcontrol.
Date: Sun, 26 Dec 2021 16:16:13 +0000

[Message part 1 (text/plain, inline)]

Attached is a patch to add the program headsetcontrol, which allows getting/setting properties for USB headsets. I've been using a previous version (2.4) locally for quite some time and it works well.

The package also builds udev rules, should a note be added to the description that it includes udev rules or anything about that?

Thanks!

John

[0001-gnu-Add-headsetcontrol.patch (text/x-patch, attachment)]

Message #8 received at 52803 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> pm.me>
To: "52803 <at> debbugs.gnu.org" <52803 <at> debbugs.gnu.org>
Subject: [PATCH v2] gnu: Add headsetcontrol.
Date: Sun, 26 Dec 2021 16:41:16 +0000

[Message part 1 (text/plain, inline)]

Forgot the copyright line, added in this version.

[0001-gnu-Add-headsetcontrol.patch (text/x-patch, attachment)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Cc: John Kehayias <john.kehayias <at> pm.me>,
 "52803 <at> debbugs.gnu.org" <52803-done <at> debbugs.gnu.org>
Subject: Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.
Date: Mon, 27 Dec 2021 10:49:57 +0100

Hello,

John Kehayias via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: Add headsetcontrol.
>
> * gnu/packages/hardware.scm (headsetcontrol): New variable.

Thank you. I pushed it with the changes detailed below.

> +(define-public headsetcontrol
> +  (package
> +    (name "headsetcontrol")
> +    (version "2.6")
> +    (source (origin
> +             (method git-fetch)

I moved `origin' below `source' and adjusted indentation.

> +             (uri (git-reference
> +                   (url "https://github.com/Sapd/HeadsetControl")
> +                   (commit version)))
> +             (file-name (git-file-name name version))
> +             (sha256
> +              (base32
> +               "0a7zimzi71416pmn6z0l1dn1c2x8p702hkd0k6da9rsznff85a88"))))

I moved hash on the same line as `base32'

> +    (build-system cmake-build-system)
> +    (inputs
> +      (list hidapi))
> +    (synopsis "Sidetone and Battery status for USB headsets")
> +    (description
> +      "A tool to control certain aspects of USB-connected headsets on Linux.

I started the description with the name of the package (guix lint
should warn you about this), and removed reference to Linux, since it is
not useful in Guix.

> +Currently, support is provided for adjusting sidetone, getting battery state,
> +controlling LEDs, and setting the inactive time.")
> +    (home-page "https://github.com/Sapd/HeadsetControl")
> +    (license license:gpl3)))

I used gpl3+ as "main.c" includes "or (at your option) any later
version" in its header.

Regards,
-- 
Nicolas Goaziou

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> pm.me>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "52803 <at> debbugs.gnu.org" <52803-done <at> debbugs.gnu.org>,
 John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.
Date: Mon, 27 Dec 2021 15:07:07 +0000

Hi Nicolas,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, December 27th, 2021 at 4:49 AM, Nicolas Goaziou wrote:

> Hello,
>
> John Kehayias via Guix-patches via guix-patches <at> gnu.org writes:
>
> > Subject: [PATCH] gnu: Add headsetcontrol.
> >
> > -   gnu/packages/hardware.scm (headsetcontrol): New variable.
>
> Thank you. I pushed it with the changes detailed below.
>

Thanks! Not sure how I missed that guix lint suggestion (I did run it), will keep a look out for that in case it did miss it for some reason.

John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.