GNU bug report logs - #52568
[PATCH] gnu: ableton-link: Run tests conditionally.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Subject: bug#52568: closed (Re: [bug#52568] [PATCH] gnu: ableton-link: Run
 tests conditionally.)
Date: Fri, 17 Dec 2021 08:37:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#52568: [PATCH] gnu: ableton-link: Run tests conditionally.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 52568 <at> debbugs.gnu.org.

-- 
52568: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52568
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 52568-done <at> debbugs.gnu.org
Subject: Re: [bug#52568] [PATCH] gnu: ableton-link: Run tests conditionally.
Date: Fri, 17 Dec 2021 09:35:58 +0100

Hello,

Aleksandr Vityazev <avityazev <at> posteo.org> writes:

> * gnu/packages/audio.scm (ableton-link)[arguments]: Respect TESTS?
> option.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ableton-link: Run tests conditionally.
Date: Fri, 17 Dec 2021 08:30:24 +0000

* gnu/packages/audio.scm (ableton-link)[arguments]: Respect TESTS? option.
---
 gnu/packages/audio.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index f5fda6d4e9..beae167fb3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5245,11 +5245,12 @@ (define-public ableton-link
        #:phases
        (modify-phases %standard-phases
          (replace 'check
-           (lambda* (#:key inputs #:allow-other-keys)
-             (let* ((python (search-input-file inputs "/bin/python3"))
-                    (run-tests "../source/ci/run-tests.py"))
-               (invoke python run-tests "--target" "LinkCoreTest")
-               (invoke python run-tests "--target" "LinkDiscoveryTest"))))
+           (lambda* (#:key inputs tests? #:allow-other-keys)
+             (when tests?
+               (let* ((python (search-input-file inputs "/bin/python3"))
+                      (run-tests "../source/ci/run-tests.py"))
+                 (invoke python run-tests "--target" "LinkCoreTest")
+                 (invoke python run-tests "--target" "LinkDiscoveryTest")))))
          (add-before 'install 'patch-cmake
            (lambda* (#:key inputs #:allow-other-keys)
              (let* ((source "../source/"))
-- 
2.34.0



-- 

Aleksandr Vityazev

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.